Adding new macro for region copy buffer size #1406
Conversation
| #define TARGET_STATIC | ||
| #endif | ||
|
|
||
| #if BOOT_MAX_ALIGN > 1024 |
There was a problem hiding this comment.
Previous values for undefined MCUBOOT_BOOT_COPY_REGION_SIZE should be kept
There was a problem hiding this comment.
I'm not sure that I follow. How are they being discarded?
In all prior versions BOOT_MAX_ALIGN > 1024 is never true, so this condition can be removed entirely. And BOOT_COPY_REGION_SIZE is only defined iff MCUBOOT_BOOT_COPY_REGION_SIZE is defined, so by default, if a user does not define MCUBOOT_BOOT_COPY_REGION_SIZE then 1024 will be used
There was a problem hiding this comment.
OK, Can you investigate CI failure?
Missing "Signed-off-by: Mikhail Skobov <mskobov@lyft.com>" in commit 7405424
There was a problem hiding this comment.
Sure thing, I will take a look later today
Signed-off-by: Mikhail Skobov <skobovm@gmail.com>
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
2 participants
This addresses the issue opened here: #1407
Background:
This PR introduced a change which appeared to be intended to allow the buffer size to be configurable.
That change, however, is frivolous because
MCUBOOT_BOOT_MAX_ALIGNis guaranteed to be between 8 and 32This PR:
This PR adds a new configuration macro to allow the region copy buffer size to be a value other than 1024, which should allow for a more efficient use of block devices when the block size is a different value.
It is backwards compatible with all version, as the default when that macro is unset is still 1024
Signed-off-by: Mikhail Skobov mskobov@lyft.com