Add allowed hash for ECDSA256P1Public key #2135
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
approved these changes
Dec 9, 2024
Author
|
I'm sorry, I didn't know I have to sign the commit. I've amended the previous commit to add signature (hopefully :D) |
Collaborator
|
Try doing |
Collaborator
|
@Salamist would you be able to fix this today or on Monday? Would like to pull latest changes into Zephyr with a manifest update soon |
de-nordic
approved these changes
Dec 13, 2024
Contributor
|
I'm having a similar problem, and I'd love to get this update soon. We can just patch our local package in the meantime. |
Collaborator
|
Brought in via #2347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've found a problem with IMGTOOL when I was trying to inject externally generated signature. (using --fix-sig and --fix-sig-pubkey options)
IMGTOOL was returning an error "Error: Colud not find allowed hash algorithms for <class 'imgtool.keys.ecdsa.ECDSA256P1Public'>"
This PR adds allowed hash (SHA256) for ECC256 Public key.