Improve TLV control under ALLOW_ROGUE_TLVS switch #2176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephane-LeRoy
force-pushed
the
main
branch
3 times, most recently
from
bfa6236 to
aca2c0a
Compare
Contributor
Author
|
Could someone help to analyze failure of FIH hardening tests? |
Collaborator
I assume your changes break it since main CI is passing fine |
Contributor
Author
|
I do not have the FIH Hardening tests running locally, and the CI logs do not help to understand the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of allowed unprotected tlvs is limited to expected TLV only, depending on crypto scheme configuration. The original implementation allows many additional TLV (related to other crypto schemes).
The allow_unprot_tlvs[] array changes requires the move of EXPECTED_ENC_TLV definitions from encrypted.c to enc_key_public.h file.