fix(onboarding): completeness indicator on the combined completion screen [re-land]#377
Merged
Merged
Conversation
- 'Name & agreements' now shows done on the completion step. It was reading the (blank) wizard form in the continuation flow instead of the fact that basics are necessarily complete once past the entry step. - Drop the filled-radio 'current' marker (it read like a selectable form radio next to the checks). Still-to-do parts are a hollow ring, highlighted in brand color for the one being filled in. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
They share one screen now, so both should read as 'being filled in' (brand- color ring) and each checks off independently — instead of photo highlighted and address greyed out like a separate later step. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands two indicator fixes that were pushed to the #376 branch after #376 was squash-merged, so they never reached
main(same stacked/late-push footgun as #373).Two fixes:
Net: on the completion screen you now see ✓ Name & agreements · ◯ Photo (blue) · ◯ Address (blue), with checks appearing as each is added.
Verification
tscand theprofileCardStatusunit test pass. Cherry-picked cleanly onto main (which already has feat(onboarding): single 'complete your card' screen with Cancel / Done #376's single-screen work).🤖 Generated with Claude Code