[pull] master from bazelbuild:master#284
Merged
pull[bot] merged 2 commits intomcx:masterfrom Feb 15, 2022
Merged
Conversation
Due to Windows forcing every dynamic library to link its dependencies, the NODEPS_DYNAMIC_LIBRARY link target type actually does link in its transitive dependencies statically on Windows. There is no reason why these cc_libraries should be link stamped though. This CL stops that. This in turn helps not trigger a MissingDepException thrown for Lexan targets with the Starlark version of cc_library. In Starlark, these exceptions are not handled. RELNOTES:none PiperOrigin-RevId: 428731905
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )