Add alias slashes#45
Closed
LKS90 wants to merge 3 commits into
Closed
Conversation
Author
There was a problem hiding this comment.
I think this edit causes some problems (sometimes deletes not enough).
There was a problem hiding this comment.
$separator is not always a slash so I think we should keep the trim() here. But, as it would have been trimmed, we should ensure that the leading char is still a slash before returning $output.
Something like this might be enough:
// If the separator is a slash, we need to re-add the leading slash dropped by the trim function.
if ($separator == '/') {
$output = '/' . $output;
}
return $output;
Member
|
Working a bit on this, can't push to this repository so i'll open a new branch/PR (why can't github fix this...). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.