migrate from net.IP to netip.Addr#27
Merged
Merged
Conversation
mdlayher
reviewed
May 12, 2022
tklauser
added a commit
to tklauser/arp
that referenced
this pull request
May 13, 2026
Use Go native fuzzing instead of gofuzz. This requires bumping the Go version in go.mod to 1.18. This is anyway needed since this modules uses the net/netip package which was introduced in Go 1.18[^1] since mdlayher#27. [^1]: https://go.dev/doc/go1.18#netip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all use of
net.IPin favor of the (smaller, faster, immutable)netip.Addr.netis still needed for the hardware address datastructures, but this will allow the results of the package to be used in maps and will permit other conveniences (like reasonable equality testing).