netlink: fix UnmarshalBinary rejecting valid unpadded netlink messages#283
Merged
nickgarlis merged 1 commit intomdlayher:mainfrom Apr 13, 2026
Merged
Conversation
parseMessagesIter passes an NLMSG_ALIGN'd slice to UnmarshalBinary, which then checks Header.Length != len(b). This fails for messages where nlmsg_len is not NLMSG_ALIGN'd. This is common with nfqueue, nflog, and conntrack events. Change the strict equality to a bounds check and trim Data to nlmsg_len to exclude padding bytes.
nickgarlis
force-pushed
the
fix-unmarshal-binary
branch
from
dca4e2b to
69d2228
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseMessagesIter passes an NLMSG_ALIGN'd slice to UnmarshalBinary, which then checks Header.Length != len(b). This fails for messages where nlmsg_len is not NLMSG_ALIGN'd. This is common with nfqueue, nflog, and conntrack events.
Change the strict equality to a bounds check and trim Data to nlmsg_len to exclude padding bytes.