Skip to content

Conversation

@mdm-code
Copy link
Owner

@mdm-code mdm-code commented Nov 4, 2024

  • Tq now expects a pointer to adapter
  • Added selector-less string filter expr
  • Added support for unquoted bare strings in query
  • Implemented literal bare key use in queries
  • Lifted new line constraint on queries and strings
  • Fixed lexer error with ws allowed
  • Adjusted parser error printer to multiline queries
  • Change error pointer indent to rely on lineOffset
  • Used lexer offset instead of the start in methods
  • Pointed to right line in lexer error
  • Added interpreter error doc string
  • Used validator func. to check if run is line break
  • Fixed error query write after offset
  • Adjusted parser error to multiline query input
  • Aligned lexer tests to multiline query input
  • Added bare strings and mulitline input query tests
  • Prototyped lexeme escape sequences on the token
  • Added escape sequence map to lexer token.
  • Split lexeme preparation to string and default
  • Removed Trim off the string AST expr
  • Allowed bare integers alongside strings
  • Allowed for escaped single and double quotes
  • Modified in-code docs to use bare multiline strs
  • Added token utest for escaped quotes in strings
  • Documented changes introducted to Tq in README
  • Fixed example test

This has been introduced to account for
implementation heavy underlying adapted
marshallers/unmarshallers.
For now, they still have to be quoted to work.
Instead of relying on the lexer to tell if it's
a given token is an escape sequence, the lexeme
will be able to represent itself accordingly.

These tokens are only allowed in quoted strings.
@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 70.42254% with 42 lines in your changes missing coverage. Please review.

Project coverage is 86.46%. Comparing base (8bfd479) to head (5951d45).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
internal/lexer/lexer.go 59.57% 18 Missing and 1 partial ⚠️
internal/parser/parser.go 25.00% 9 Missing ⚠️
internal/lexer/error.go 66.66% 3 Missing and 2 partials ⚠️
internal/parser/error.go 68.75% 3 Missing and 2 partials ⚠️
internal/lexer/token.go 92.10% 2 Missing and 1 partial ⚠️
internal/lexer/validate.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   90.35%   86.46%   -3.90%     
==========================================
  Files          12       12              
  Lines         726      820      +94     
==========================================
+ Hits          656      709      +53     
- Misses         51       86      +35     
- Partials       19       25       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdm-code mdm-code self-assigned this Nov 4, 2024
@mdm-code mdm-code added the enhancement New feature or request label Nov 4, 2024
@mdm-code mdm-code merged commit 1a1a697 into main Nov 4, 2024
4 of 6 checks passed
@mdm-code mdm-code deleted the improve-querying branch November 4, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants