-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Update MediaStreamTrackProcessor spec_url and mark Chrome constructor support as partial #26519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note: We don't add |
caugner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the notes more concise.
Did you want to add similar notes to VideoTrackGenerator?
more concise notes Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
No, since Chrome does not implement VideoTrackGenerator. When they do it will hopefully be on DedicatedWorker. |
caugner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec defines exposure on the interface, not on its members, so I don't think it's right to set partial_implementation: true on the members, especially not on the readable property.
I acknowledge that it can be confusing that this limitation is not visible on the MediaStreamTrackProcessor constructor page, but I don't think updating the data like this is the right approach. Instead, I'm thinking that the BCD tables on MDN could include rows for the parent feature, while highlighting the feature corresponding to the current page.
I added this issue to the agenda of the next BCD meeting, so that we decide how to proceed.
We discussed this in today's BCD meeting, and for now we accept (but don't require) |
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Summary
Add mdn links to VideoTrackGeneratorTest results and supporting details
npm testverified JSON, but complains of missing mdn links for VideoTrackGenerator (coming in mdn/content#39124).couldn't get
npm run statsto work, so hopefully things look OK.Spec: https://w3c.github.io/mediacapture-transform/