-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(lint): check + fix hash of MDN urls #26598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
7f9c4e6 to
1109f58
Compare
Ran `npx tsx scripts/check-mdn-url-anchors.ts`, then manually checked each link to see if the anchor has changed, or if the page no longer has a matching anchor for the referenced feature.
1109f58 to
8d25080
Compare
Elchi3
approved these changes
Apr 25, 2025
Member
Elchi3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
data:api
Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
data:css
Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
data:html
Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
data:js
Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
data:webext
Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
infra
Infrastructure issues (npm, GitHub Actions, releases) of this project
linter
Issues or pull requests regarding the tests / linter of the JSON files.
scripts
Issues or pull requests regarding the scripts in scripts/.
size:l
[PR only] 101-1000 LoC changed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a lint that checks the hash of
mdn_urls to ensure they're lowercase.Fixes all errors, and removes some no-longer existing anchors.
Also adds a
check-mdn-url-anchorsscript that fetches all MDN urls with a fragment, and checks whether the page contains the anchor.Test results and supporting details
Related issues
Fixes #26597.