Skip to content

Conversation

@chrisdavidmills
Copy link
Contributor

…script element type attribute

@teoli2003
Copy link
Contributor

@chrisdavidmills This looks strange… Do you have the bug #?

@teoli2003 teoli2003 added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jan 23, 2018
@chrisdavidmills
Copy link
Contributor Author

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change and we are good.

},
"version_parameter": {
"__compat": {
"description": "The <code>version</code> parameter of the <code>type</code> attribute.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug #, it makes sense now.

No dot at the end of description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@teoli2003 teoli2003 changed the title adding entry for support/removal of proprietary version parameter of … Add support removal of Firefox-only 'version' parameter in 'type' attribute of <script> Jan 24, 2018
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

@Elchi3 Elchi3 dismissed teoli2003’s stale review January 25, 2018 14:34

Review comments are addressd now

@Elchi3 Elchi3 merged commit 44a9793 into mdn:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants