Add InheritanceDiagram to some WebXR event pages#11025
Merged
Conversation
Contributor
Contributor
|
I like it with the text alongside. 👍 |
Collaborator
|
I like this proposal. I'm happy to merge for you if we have consensus. |
23a1d71 to
df7b211
Compare
Member
Author
|
Rebased to not update inheritance data here. I merged #8797 instead. |
Member
Author
It seems this proposal has indeed consensus. At least I haven't heard otherwise. |
Collaborator
|
Yeh I'm into it! Looks good @Elchi3 👍 |
Member
Author
|
mdn/yari#5056 will make this a lot better and avoid the weird sizing parameters. Converting to draft for the moment. |
096858f to
0352150
Compare
Member
Author
|
mdn/yari#5056 landed so this PR works nicely now :) |
Collaborator
|
So we're good to go @Elchi3 ? |
Member
Author
|
@Rumyra Yes we are :) |
Rumyra
approved these changes
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #10923 (comment) and https://github.com/mdn/content/discussions/10544#discussioncomment-1739581
Thoughts?