Itemize 0, -0, 0n, -0n separately in Falsy doc#1931
Merged
Conversation
sideshowbarker
requested review from
a team and
chrisdavidmills
and removed request for
a team
Closed
|
Well, |
sideshowbarker
force-pushed
the
sideshowbarker/falsy-values-further-itemize
branch
from
3a5201e to
5780020
Compare
Member
Author
OK, thanks — amended the commit to correct that part. Please take another look and let me know if it looks OK now. |
|
Yep, looks good now. Thanks! :) |
Member
Author
Thanks for you review! |
chrisdavidmills
approved these changes
Feb 1, 2021
chrisdavidmills
left a comment
chrisdavidmills
left a comment
Contributor
There was a problem hiding this comment.
LGTM, cheers @sideshowbarker !
chrisdavidmills
deleted the
sideshowbarker/falsy-values-further-itemize
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1309 (comment)