Addition of browser_specific_settings.gecko_android by rebloor · Pull Request #26171 · mdn/content

rebloor · 2023-04-13T02:31:11Z

Description

As details of the new gecko_android sudkey in the android_specific_settings manifest key.

Also, removed the description of Microsoft Edge properties, which haven't been supported since it adopted Chromium, and remove the note about the safari subkey causing issues in Firefox 69 or earlier.

Motivation

Addresses the BCD requirements of Bug 1824237 Add support for new browser_specific_settings.gecko_android key.

Related issues and pull requests

Related BCD changes in PR #19363.

github-actions · 2023-04-13T02:33:22Z

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/113
Title: Firefox 113 for developers
Flaw count: 1

broken_links:
- Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings

External URLs (3)

URL: /en-US/docs/Mozilla/Firefox/Releases/113
Title: Firefox 113 for developers

https://bugzil.la/1824237 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings
Title: browser_specific_settings

https://extensionworkshop.com/documentation/develop/extensions-and-the-add-on-id/ (2 times) (Note! This may be a new URL 👀)
https://extensionworkshop.com/documentation/manage/updating-your-extension/ (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2023-04-24 18:00:23)

willdurand · 2023-04-13T08:07:35Z

files/en-us/mozilla/add-ons/webextensions/manifest.json/browser_specific_settings/index.md

-  - : The extension ID. For extensions submitted to [addons.mozilla.org](https://addons.mozilla.org/) (AMO), see [Extensions and the Add-on ID](https://extensionworkshop.com/documentation/develop/extensions-and-the-add-on-id/) to determine when you need to specify the ID. When required by AMO, this property must contain 80 characters or less. For extensions not submitted to AMO, if the extension is unsigned (and not loaded using `about:debugging`) an ID is required; otherwise, ID is optional.
+  - : The extension ID. For extensions submitted to [addons.mozilla.org](https://addons.mozilla.org/) (AMO), see [Extensions and the Add-on ID](https://extensionworkshop.com/documentation/develop/extensions-and-the-add-on-id/) to determine when to specify the ID. When required by AMO, this property must contain 80 characters or less. For extensions not submitted to AMO, an ID is required if the extension is unsigned (and not loaded using `about:debugging`); otherwise, an ID is optional.
 - `strict_min_version`
  - : Minimum version of Gecko to support. Versions containing a "\*" are not valid in this field. Defaults to "42a1".


I don't think there is a default value, especially not 42a1.

@willdurand I assume that one of these must apply:

when not provided, there is a default

is mandatory if you also state gecko.strict_max_version

when not provided, it takes the value of gecko.strict_max_version.

when not provided, (based on your feedback about back at gecko_android) installs on whatever minimum version is supported by AMO
Can you confirm which one?

when not provided, there is a default

there is no default AFAICT, it's therefore compatible.

is mandatory if you also state gecko.strict_max_version

no, min version isn't mandatory even when max version is specified

when not provided, it takes the value of gecko.strict_max_version.

it does not

when not provided, (based on your feedback about back at gecko_android) installs on whatever minimum version is supported by AMO

that is different, AMO has its own compatibility range.

the absence of this value means it is compatible

willdurand · 2023-04-13T08:15:00Z

files/en-us/mozilla/add-ons/webextensions/manifest.json/browser_specific_settings/index.md

+The `gecko_android` subkey supports these properties:
+
+- `strict_min_version`
+  - : Minimum version of Gecko to support. Versions containing a "\*" are not valid in this field. Defaults to "42a1".


I don't think the default value is 42a1. There is no default in Firefox for this property. If this property is omitted, gecko.strict_min_version is used instead.

AMO has a default value that might change in the future but we shouldn't document it here anyway.

dipikabh

A tiny nit in the release note

dipikabh · 2023-04-20T12:31:44Z

files/en-us/mozilla/firefox/releases/113/index.md


 - When an extension registers multiple listeners for the same event, all the event listeners are called when the event page wakes up, instead of only the first one ([Firefox bug 1798655](https://bugzil.la/1798655)).
 - Support is now provided for the {{WebExtAPIRef("declarativeNetRequest")}} API ([Firefox bug 1782685](https://bugzil.la/1782685)).
+- Adds a `gecko_android` subkey to the [`browser_specific_settings`](/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings) key to enable an extension to specify the range of Firefox for Android versions it is compatible with ([Firefox bug 1824237](https://bugzil.la/1824237)).


Suggested change

- Adds a `gecko_android` subkey to the [`browser_specific_settings`](/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings) key to enable an extension to specify the range of Firefox for Android versions it is compatible with ([Firefox bug 1824237](https://bugzil.la/1824237)).

- A new `gecko_android` subkey is added to the [`browser_specific_settings`](/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings) key. This subkey allows you to specify the range of Firefox for Android versions it is compatible with ([Firefox bug 1824237](https://bugzil.la/1824237)).

A couple of points here:

"A new … is added" adds unnecessary redundancy and could be read to suggest that there was an "old" gecko_android subkey here too. It also feels like a slightly old construct for modern English.

while the original sentence is long, at 25 words, it's just on the limit of what's considered readable. Although I would agree that splitting it is preferable.

the key doesn't "allow" it "enables". That is, it does not give you permission to specify the range of versions, it provides you with the ability to specify the range of versions.

Thanks for also correcting the distinction between the doer - 'allows "you"' vs 'enables "an extension"'.

FYI the difference between allows and enables is not the actor it's the action. It's the difference between a fishing rod enabling someone to fish and a fishing license allowing someone to fish.

…android

files/en-us/mozilla/firefox/releases/113/index.md

dipikabh

Thanks 👍

…android

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

dipikabh · 2023-04-23T22:33:58Z

Changes look good to me, @rebloor. I've marked my approval.

files/en-us/mozilla/add-ons/webextensions/manifest.json/browser_specific_settings/index.md

Co-authored-by: William Durand <will+git@drnd.me>

…android

Addition of browser_specific_settings.gecko_android

c8f71dd

rebloor added the Content:WebExt WebExtensions docs label Apr 13, 2023

rebloor requested a review from willdurand April 13, 2023 02:31

rebloor requested a review from a team as a code owner April 13, 2023 02:31

rebloor self-assigned this Apr 13, 2023

rebloor requested a review from a team as a code owner April 13, 2023 02:31

rebloor requested review from dipikabh and removed request for a team April 13, 2023 02:31

github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Apr 13, 2023

rebloor mentioned this pull request Apr 13, 2023

Addition of browser_specific_settings.gecko_android mdn/browser-compat-data#19363

Merged

willdurand requested changes Apr 13, 2023

View reviewed changes

Updates for feedback

ced984b

rebloor requested a review from willdurand April 18, 2023 21:52

dipikabh requested changes Apr 20, 2023

View reviewed changes

rebloor added 2 commits April 21, 2023 03:11

Merge branch 'main' into addition-of-browser_specific_settings.gecko_…

34c4264

…android

Feedback update to release note

dec7f8c

rebloor requested a review from dipikabh April 20, 2023 15:18

dipikabh requested changes Apr 21, 2023

View reviewed changes

files/en-us/mozilla/firefox/releases/113/index.md Outdated Show resolved Hide resolved

willdurand enabled auto-merge (squash) April 23, 2023 11:40

dipikabh approved these changes Apr 23, 2023

View reviewed changes

dipikabh and others added 3 commits April 23, 2023 08:13

Merge branch 'main' into addition-of-browser_specific_settings.gecko_…

2295804

…android

Merge branch 'main' into addition-of-browser_specific_settings.gecko_…

daa3acf

…android

Consistency feedback

a2a3efa

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

rebloor requested a review from dipikabh April 23, 2023 16:18

willdurand requested changes Apr 24, 2023

View reviewed changes

files/en-us/mozilla/add-ons/webextensions/manifest.json/browser_specific_settings/index.md Outdated Show resolved Hide resolved

files/en-us/mozilla/add-ons/webextensions/manifest.json/browser_specific_settings/index.md Outdated Show resolved Hide resolved

rebloor and others added 2 commits April 25, 2023 05:56

Apply suggestions from review

38427d9

Co-authored-by: William Durand <will+git@drnd.me>

Merge branch 'main' into addition-of-browser_specific_settings.gecko_…

9ad05f0

…android

rebloor requested a review from willdurand April 24, 2023 17:59

willdurand approved these changes Apr 24, 2023

View reviewed changes

willdurand merged commit 23346b5 into mdn:main Apr 24, 2023

rebloor deleted the addition-of-browser_specific_settings.gecko_android branch April 24, 2023 21:49

	- Adds a `gecko_android` subkey to the [`browser_specific_settings`](/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings) key to enable an extension to specify the range of Firefox for Android versions it is compatible with ([Firefox bug 1824237](https://bugzil.la/1824237)).
	- A new `gecko_android` subkey is added to the [`browser_specific_settings`](/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings) key. This subkey allows you to specify the range of Firefox for Android versions it is compatible with ([Firefox bug 1824237](https://bugzil.la/1824237)).

Conversation

rebloor commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation

Related issues and pull requests

Uh oh!

github-actions bot commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

willdurand Apr 13, 2023

Choose a reason for hiding this comment

Uh oh!

rebloor Apr 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

willdurand Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

willdurand Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

willdurand Apr 13, 2023

Choose a reason for hiding this comment

Uh oh!

dipikabh left a comment

Choose a reason for hiding this comment

Uh oh!

dipikabh Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

rebloor Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dipikabh Apr 21, 2023

Choose a reason for hiding this comment

Uh oh!

rebloor Apr 23, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dipikabh left a comment

Choose a reason for hiding this comment

Uh oh!

dipikabh commented Apr 23, 2023

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rebloor commented Apr 13, 2023 •

edited

Loading

github-actions bot commented Apr 13, 2023 •

edited

Loading

rebloor Apr 15, 2023 •

edited

Loading

rebloor Apr 20, 2023 •

edited

Loading