Fix web_accessible_resources and link relevant DNR examples#26801
Merged
Fix web_accessible_resources and link relevant DNR examples#26801
Conversation
github-actions
bot
added
the
Content:Other
Contributor
|
Preview URLs
(comment last updated: 2023-05-16 16:01:01) |
web_accessible_resources had several flaws: - The types were not documented to be arrays. - It was not obvious which properties were optional. - The "Example" section only listed MV2, not MV3. - `*` as value in `extension_ids` was not documented. - The docs states "Paths are ignored.", but that is not the case in any browser, see https://bugzilla.mozilla.org/show_bug.cgi?id=1833415 This PR also links to new examples in the mdn/webextensions-examples repository that demonstrates the use of `web_accessible_resources` in MV2 and MV3.
Rob--W
force-pushed
the
webext-manifest-mv3-war-and-dnr
branch
from
2555916 to
e4b464e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
web_accessible_resources had several flaws:
*as value inextension_idswas not documented.This PR also links to new examples in the mdn/webextensions-examples repository that demonstrates the use of
web_accessible_resourcesin MV2 and MV3.Motivation
Additional details
Related issues and pull requests