Merged
Conversation
github-actions
bot
added
the
Content:Other
Contributor
|
Preview URLs
External URLs (1)URL:
(comment last updated: 2023-06-15 23:32:27) |
Rob--W
approved these changes
Jun 15, 2023
Member
Rob--W
left a comment
Rob--W
left a comment
There was a problem hiding this comment.
Looks good, I'm confident that you can address the feedback without another review.
files/en-us/mozilla/add-ons/webextensions/api/runtime/setuninstallurl/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Rob Wu <rob@robwu.nl>
Rob--W
reviewed
Jun 16, 2023
| {{AddonSidebar()}} | ||
|
|
||
| Sets the URL to be visited when the extension is uninstalled. This may be used to clean up server-side data, do analytics, or implement surveys. The URL can be a maximum 255 characters. | ||
| Sets the URL to be visited when the extension is uninstalled. This can be used to clean up server-side data, do analytics, or implement surveys. Up to Firefox 115, a maximum of 255 characters can be used; from Firefox 116, the maximum is 1023 characters. |
Member
There was a problem hiding this comment.
This documentation is too Firefox-specific.
Please rephrase to state that the limit is 1023, and add a note that it used to be smaller with a reference to the BCD.
Firefox 115- and Chrome 114- had 255 as a limit.
Reference for Chrome: https://groups.google.com/a/chromium.org/g/chromium-extensions/c/XQICoHfau9g/m/3Dx-5b8HCQAJ
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide the documentation for Bug 1835723 setUninstallURL should be updated to 1023