Fix #30443 Inconsistent syntax in repeated code snippets#30476
Merged
hamishwillee merged 2 commits intomdn:mainfrom Nov 26, 2023
Merged
Fix #30443 Inconsistent syntax in repeated code snippets#30476hamishwillee merged 2 commits intomdn:mainfrom
hamishwillee merged 2 commits intomdn:mainfrom
Conversation
Contributor
This was referenced Nov 23, 2023
Collaborator
|
This looks great, but I will have to run your update in the demo project to test it first (mdn/express-locallibrary-tutorial#245). PRobably Monday. |
hamishwillee
approved these changes
Nov 26, 2023
Collaborator
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
This is a lot cleaner. Thanks very much, and welcome to MDN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Address inconsistency by replacing syntax that had been written in two different ways in the tutorial.
Motivation
It was confusing seeing references to the same file that used different syntax within the same function.
Additional details
Related issues and pull requests
Fixes #30443
Relates to mdn/express-locallibrary-tutorial/pull/245