Call super first in custom element constructor#31308
Merged
hamishwillee merged 1 commit intomdn:mainfrom Dec 26, 2023
jbilee:patch-2
Merged
Call super first in custom element constructor#31308hamishwillee merged 1 commit intomdn:mainfrom jbilee:patch-2
hamishwillee merged 1 commit intomdn:mainfrom
jbilee:patch-2
Conversation
Contributor
hamishwillee
approved these changes
Dec 26, 2023
Collaborator
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
Thanks very much @jbilee - our own guidance says "Always call super first in constructor" though I didn't know that this would result in a reference error.
... and welcome to MDN.
dipikabh
pushed a commit
to dipikabh/content
that referenced
this pull request
Jan 17, 2024
Switch line order in custom element constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
super()was not called first in the constructor of a custom element, so I fixed it.Motivation
The current code snippet results in a reference error. I'd like to contribute to the readers' learning experience by proposing a change to the code snippet.
Additional details
Related issues and pull requests