Add HTMLTableCellElement.{align|vAlign} by teoli2003 · Pull Request #32993 · mdn/content

teoli2003 · 2024-04-08T07:42:56Z

Description

This PR adds docs for the two properties:

HTMLTableCellElement.align
HTMLTableCellElement.valign

Motivation

These properties are supported by all engines.

Though deprecated, they are common tasks for beginners: we need documentation that points to the right way of doing this (TM), using text-align and vertical-align

Additional details

There is no example as this is deprecated: the example sections point to examples using the modern (CSS) way of doing it so that they are one click away.

Related issues and pull requests

It is part of mdn/mdn#520

github-actions · 2024-04-08T07:44:14Z

Preview URLs

Flaws (13)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLTableCellElement
Title: HTMLTableCellElement
Flaw count: 13

macros:
- /en-US/docs/Web/API/HTMLTableCellElement/abbr does not exist
- /en-US/docs/Web/API/HTMLTableCellElement/cellIndex does not exist
- /en-US/docs/Web/API/HTMLTableRowElement/cells does not exist
- /en-US/docs/Web/API/HTMLTableCellElement/colSpan does not exist
- /en-US/docs/Web/API/HTMLTableCellElement/headers does not exist
- and 8 more flaws omitted

(comment last updated: 2024-04-10 15:01:55)

estelle

I realize these are deprecated, but they both get and set. The "get" any value, even if not valid, with empty string if not present.

estelle · 2024-04-08T18:01:24Z

files/en-us/web/api/htmltablecellelement/align/index.md

+
+{{APIRef("HTML DOM")}}{{deprecated_header}}
+
+The **`HTMLTableCellElement.align`** property is a string indicating how to horizontally align text in the cell.


Suggested change

The **`HTMLTableCellElement.align`** property is a string indicating how to horizontally align text in the cell.

The **`HTMLTableCellElement.align`** property is a string indicating how to horizontally align text in the {{htmlelement("th")}} or {{htmlelement("td")}} table cell.

we should include the two elements on which it is used as links. Not sure about having to mention "table", or linking to that.

also, it's a setter, but not a getter. should we mention that?

Commited.

According to the IDL it is both a setter and a getter. (But it ignores the value of text-align of course). I don't think it needs more info here.

files/en-us/web/api/htmltablecellelement/align/index.md

estelle · 2024-04-08T18:18:26Z

files/en-us/web/api/htmltablecellelement/align/index.md

+
+The **`HTMLTableCellElement.align`** property is a string indicating how to horizontally align text in the cell.
+
+**Note:** This property is deprecated and CSS should be used to horizontally align text in a cell. Use the {{cssxref("text-align")}} property instead.


Suggested change

**Note:** This property is deprecated and CSS should be used to horizontally align text in a cell. Use the {{cssxref("text-align")}} property instead.

**Note:** This property is deprecated. Use the CSS {{cssxref("text-align")}} property, which takes precedence, to horizontally align text in a cell instead.

we should mention that it this JS has no effect if this property is set. this is my way of suggesting it. you may have a better suggestion.

files/en-us/web/api/htmltablecellelement/align/index.md

files/en-us/web/api/htmltablecellelement/index.md

estelle · 2024-04-08T18:40:03Z

files/en-us/web/api/htmltablecellelement/valign/index.md

+
+## Value
+
+The possible values are:


Pretty sure the values were top, bottom, center, middle, and baseline. IE5 supported justify as well.

Yes, you are right. Fixing. We don't need to list justify anymore, though.

files/en-us/web/api/htmltablecellelement/valign/index.md

files/en-us/web/css/text-align/index.md

files/en-us/web/api/htmltablecellelement/align/index.md

files/en-us/web/api/htmltablecellelement/valign/index.md

Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com>

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

files/en-us/web/css/text-align/index.md

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

teoli2003 · 2024-04-10T12:57:54Z

I think I have addressed (or answered) all points. Ready for a second pass.

teoli2003 · 2024-04-10T13:00:34Z

(The linting failing test seems bogus. There are no errors listed, and I pushed from local, so the linter ran locally too (without error)

files/en-us/web/api/htmltablecellelement/index.md

estelle · 2024-04-10T14:38:45Z

(The linting failing test seems bogus. There are no errors listed, and I pushed from local, so the linter ran locally too (without error)

I think the error was a simple space missing. If it's going to error, it should list the error. I found it by looking at the commit that first produced the green X. committing the space addition seems to have brought back the green x.

estelle

a few edits, but approving to not hold you up.

files/en-us/web/api/htmltablecellelement/index.md

files/en-us/web/api/htmltablecellelement/valign/index.md

files/en-us/web/css/text-align/index.md

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

teoli2003 · 2024-04-10T15:01:18Z

Thank you, @estelle!

Add HTMLTableCellElement.{align|vAlign}

2be4861

teoli2003 requested review from a team as code owners April 8, 2024 07:42

teoli2003 requested review from chrisdavidmills and wbamberg and removed request for a team April 8, 2024 07:42

github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Apr 8, 2024

teoli2003 requested a review from estelle April 8, 2024 07:47

Fix typo

84160fc

chrisdavidmills removed their request for review April 8, 2024 10:14

estelle reviewed Apr 8, 2024

View reviewed changes

skyclouds2001 reviewed Apr 10, 2024

View reviewed changes

wbamberg removed their request for review April 10, 2024 06:24

teoli2003 and others added 13 commits April 10, 2024 10:29

Update files/en-us/web/api/htmltablecellelement/align/index.md

bf51300

Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com>

Update files/en-us/web/api/htmltablecellelement/align/index.md

ddb5ac6

Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com>

Update files/en-us/web/api/htmltablecellelement/valign/index.md

56464b4

Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com>

Update files/en-us/web/api/htmltablecellelement/valign/index.md

b6ca1c0

Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com>

Update files/en-us/web/css/text-align/index.md

cd8fa93

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Update files/en-us/web/api/htmltablecellelement/align/index.md

1c94cc9

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Update files/en-us/web/api/htmltablecellelement/align/index.md

e204365

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Update files/en-us/web/api/htmltablecellelement/align/index.md

df4ea50

Update files/en-us/web/api/htmltablecellelement/align/index.md

7428ff7

Update index.md

7aa0f53

Update files/en-us/web/css/text-align/index.md

afd7c19

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Update files/en-us/web/api/htmltablecellelement/index.md

605556f

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Update files/en-us/web/api/htmltablecellelement/valign/index.md

f26b0ed

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

github-actions bot reviewed Apr 10, 2024

View reviewed changes

files/en-us/web/css/text-align/index.md Outdated Show resolved Hide resolved

teoli2003 and others added 6 commits April 10, 2024 11:22

Update files/en-us/web/css/text-align/index.md

03087d8

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Update files/en-us/web/css/text-align/index.md

a7e63ea

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Update files/en-us/web/css/text-align/index.md

c72dbab

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update files/en-us/web/api/htmltablecellelement/valign/index.md

7200578

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Update files/en-us/web/api/htmltablecellelement/valign/index.md

b7d02bc

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Last edits from comments + minor fixes

e5c89ae

teoli2003 requested a review from estelle April 10, 2024 13:00

estelle reviewed Apr 10, 2024

View reviewed changes

files/en-us/web/api/htmltablecellelement/index.md Outdated Show resolved Hide resolved

Update files/en-us/web/api/htmltablecellelement/index.md

dd1b025

estelle approved these changes Apr 10, 2024

View reviewed changes

teoli2003 and others added 5 commits April 10, 2024 17:00

Update files/en-us/web/api/htmltablecellelement/index.md

a7a3cd4

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Update files/en-us/web/api/htmltablecellelement/valign/index.md

114b3dd

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Update files/en-us/web/api/htmltablecellelement/valign/index.md

92b6910

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Update files/en-us/web/css/text-align/index.md

af181b8

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Update files/en-us/web/api/htmltablecellelement/valign/index.md

3cac8a1

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

teoli2003 merged commit 6c858b4 into mdn:main Apr 10, 2024

This was referenced Apr 11, 2024

Add HTMLTable*Element.{valign|align} #33035

Merged

Add HTMLTableColElement.{align|valign} #33101

Merged


		{{APIRef("HTML DOM")}}{{deprecated_header}}

		The `HTMLTableCellElement.align` property is a string indicating how to horizontally align text in the cell.


		The `HTMLTableCellElement.align` property is a string indicating how to horizontally align text in the cell.

		Note: This property is deprecated and CSS should be used to horizontally align text in a cell. Use the {{cssxref("text-align")}} property instead.

	Note: This property is deprecated and CSS should be used to horizontally align text in a cell. Use the {{cssxref("text-align")}} property instead.
	Note: This property is deprecated. Use the CSS {{cssxref("text-align")}} property, which takes precedence, to horizontally align text in a cell instead.

Conversation

teoli2003 commented Apr 8, 2024

Description

Motivation

Additional details

Related issues and pull requests

Uh oh!

github-actions bot commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

estelle left a comment

Choose a reason for hiding this comment

Uh oh!

estelle Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

teoli2003 Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

estelle Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

teoli2003 Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

estelle Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

teoli2003 Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

teoli2003 commented Apr 10, 2024

Uh oh!

teoli2003 commented Apr 10, 2024

Uh oh!

Uh oh!

estelle commented Apr 10, 2024

Uh oh!

estelle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

teoli2003 commented Apr 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Apr 8, 2024 •

edited

Loading