Skip to content

<link rel=preload> Talk abstractly about "preload resource" rather than "image"#33045

Merged
wbamberg merged 2 commits intomdn:mainfrom
tomayac:patch-25
Apr 11, 2024
Merged

<link rel=preload> Talk abstractly about "preload resource" rather than "image"#33045
wbamberg merged 2 commits intomdn:mainfrom
tomayac:patch-25

Conversation

@tomayac
Copy link
Copy Markdown
Contributor

@tomayac tomayac commented Apr 11, 2024

Description

The docs talk specifically about images when it's applicable to more resource types.

Motivation

Clarify use cases.

Additional details

Related issues and pull requests

@tomayac tomayac requested a review from a team as a code owner April 11, 2024 15:39
@tomayac tomayac requested review from wbamberg and removed request for a team April 11, 2024 15:39
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Apr 11, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 11, 2024

Preview URLs

(comment last updated: 2024-04-11 17:05:09)

@wbamberg
Copy link
Copy Markdown
Collaborator

I was going to say, is there a definition of "type" we can link to, to explain "of the same type"? (we would only need to link it in the first occurrence, which is in the preamble paragraph). But there are quite a few places where we use this formulation (e.g. https://developer.mozilla.org/en-US/docs/Web/API/fetch#priority) so it would be a bit of a can of worms.

Is it https://developer.mozilla.org/en-US/docs/Web/API/Request/destination ?

@tomayac
Copy link
Copy Markdown
Contributor Author

tomayac commented Apr 11, 2024

@tomayac
Copy link
Copy Markdown
Contributor Author

tomayac commented Apr 11, 2024

Linked the type in 9f7c780 now.

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Apr 11, 2024
Copy link
Copy Markdown
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @tomayac !

@wbamberg wbamberg merged commit 6fc2b5d into mdn:main Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants