Update Intl.DateTimeFormat to reflect new behaviour of hourCycle option#33343
Merged
Update Intl.DateTimeFormat to reflect new behaviour of hourCycle option#33343
Intl.DateTimeFormat to reflect new behaviour of hourCycle option#33343Conversation
github-actions
Bot
added
Content:JS
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Preview URLs (comment last updated: 2024-05-01 00:35:41) |
…imeformat/datetimeformat/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the description of
hourCycleoption to reflect the current spec, which uses locale-dependent data to determine what hour cycles should be used for each locale whenhourCycleis set.Motivation
tc39/ecma402#758 changed how this option is interpreted; previous versions used very buggy algorithm to determine which hour cycle to use.
Note that no locale uses the
"h24"hour cycle, and only one region (JP) uses"h11".