webRequest.getSecurityInfo options parameter optional#35345
Merged
rebloor merged 4 commits intoAug 8, 2024
Merged
Conversation
rebloor
requested review from
Rob--W and
pepelsbey
and removed request for
a team
github-actions
Bot
added
Content:Firefox
Contributor
|
Preview URLs
External URLs (1)URL:
(comment last updated: 2024-08-08 17:22:07) |
Rob--W
approved these changes
Aug 7, 2024
Member
Rob--W
left a comment
Rob--W
left a comment
There was a problem hiding this comment.
Approved with the requested change applied.
| - `requestId` | ||
| - : `string`. ID of the request for which you want security info. You can get this from the `details` object that is passed into any `webRequest` event listeners. | ||
| - `options` | ||
| - `options` {{optional_inline}} |
Member
There was a problem hiding this comment.
Above at line 23, change "object" to "optional object" too.
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
rebloor
deleted the
webRequest.getSecurityInfo-options-parameter-required
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documents the change made in Bug 1909474 webRequest.getSecurityInfo() options parameter is documented as optional but cannot be optional
Related issues and pull requests
Related BCD change in mdn/browser-compat-data#24056