Conversation
Contributor
|
Preview URLs |
Josh-Cena
approved these changes
Jan 10, 2025
Member
Josh-Cena
left a comment
There was a problem hiding this comment.
I suppose this remark was made in ancient times, when people were still using alert() as a normal debugging device. The time has passed and we no longer do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I removed a paragraph that doesn't seem to convey any useful information.
Motivation
Good documentation is concise.
Additional details
If I'm wrong, I hope someone can explain what the purpose of this paragraph is, and how it's likely to help the reader.
To clarify, I don't understand what “comparing range and text” is supposed to mean, and why anyone would imagine using alert dialogs is an effective way of accomplishing this task. Without that context, the remark that “Alerting the contents of a Range makes an implicit toString() call” is superfluous, because that's what
alert()always does.Related issues and pull requests
None.