Skip to content

Move guide to module: scroll anchoring.#38593

Merged
chrisdavidmills merged 5 commits intomainfrom
mv_saguide
Mar 20, 2025
Merged

Move guide to module: scroll anchoring.#38593
chrisdavidmills merged 5 commits intomainfrom
mv_saguide

Conversation

@estelle
Copy link
Member

@estelle estelle commented Mar 12, 2025

moved the guide to be in the folder of the new module landing page.
added links to the module

#218

@estelle estelle requested review from a team as code owners March 12, 2025 19:16
@estelle estelle requested review from dipikabh and removed request for a team March 12, 2025 19:16
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries size/s [PR only] 6-50 LoC changed labels Mar 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

Preview URLs (9 pages)
Flaws (4)

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_scroll_snap
Title: CSS scroll snap
Flaw count: 2

  • broken_links:
    • /en-US/docs/Glossary/scroll_container is ill cased
  • macros:
    • Macro produces link /en-US/docs/Glossary/scroll_container which is a redirect

URL: /en-US/docs/Web/CSS/CSS_scroll_anchoring/Scroll_anchoring
Title: Understanding scroll anchoring
Flaw count: 2

  • broken_links:
    • /en-US/docs/Glossary/scroll_container is ill cased
  • macros:
    • Macro produces link /en-US/docs/Glossary/scroll_container which is a redirect
External URLs (2)

URL: /en-US/docs/Web/CSS/CSS_scroll_anchoring/Scroll_anchoring
Title: Understanding scroll anchoring

(comment last updated: 2025-03-12 19:45:20)

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Mar 12, 2025
@sideshowbarker sideshowbarker removed the request for review from a team March 13, 2025 05:05
@estelle estelle requested a review from chrisdavidmills March 13, 2025 19:35
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking mostly good, @estelle; just a few small suggestions to consider.

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle estelle requested a review from chrisdavidmills March 17, 2025 16:48
…x.md

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle estelle requested a review from dipikabh March 18, 2025 20:39
@dipikabh
Copy link
Contributor

I'll let @chrisdavidmills do the final review

@estelle
Copy link
Member Author

estelle commented Mar 20, 2025

@chrisdavidmills When you have a chance, would love to move this to merged ;)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle perfect; merging!

@chrisdavidmills chrisdavidmills merged commit a7335ef into main Mar 20, 2025
13 checks passed
@chrisdavidmills chrisdavidmills deleted the mv_saguide branch March 20, 2025 14:53
cssinate pushed a commit to cssinate/content that referenced this pull request Apr 11, 2025
* Move guide

* add links to new module landing page

* tweaks

* committing suggestions

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>

* Update files/en-us/web/css/css_scroll_anchoring/scroll_anchoring/index.md

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

---------

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments