Use Object.hasOwn on undefined and null property values
#38853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In my experience, the output of `Object.hasOwn` on `undefined`/`null` property values is unexpected, so I wanted to document it in the example.
github-actions
bot
added
Content:JS
Contributor
Member
|
Thanks. This is an interactive example, whose goal is to offer a quick taste of the API, not every aspect of its functionality. We demonstrate three things here: an existing own property, an existing property on the prototype, and a nonexistent property, which is more than enough to cover the whole algorithm anyway. I agree we should have examples demonstrating nullish properties, but they should go into the actual example section. |
Member
|
Actually we already have examples for these below. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
Object.hasOwnon undefined and null property valuesMotivation
Object.hasOwnonundefined/nullproperty values can be unexpected, so I wanted to document it in the example.Additional details
Related issues and pull requests