Skip to content

Conversation

@dbarabashh
Copy link
Contributor

@dbarabashh dbarabashh commented Apr 5, 2025

Fix #36458

@dbarabashh dbarabashh requested a review from a team as a code owner April 5, 2025 14:08
@dbarabashh dbarabashh requested review from chrisdavidmills and removed request for a team April 5, 2025 14:08
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Apr 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2025

@Josh-Cena Josh-Cena requested a review from captainbrosset April 5, 2025 15:38
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbarabashh thanks for the contribution! I've added some thoughts on how I think this could be handled.

@dbarabashh
Copy link
Contributor Author

I made some changes and updated the text, but I have a feeling its a bit hard to understand. Considering less experienced developers, this explanation might be too complex. What do you think?

/cc @chrisdavidmills

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbarabashh It's getting there. A couple more comments for you.

I also wondered if you could link to this section from all the pseudo-element reference pages that follow this inheritance model?

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Apr 12, 2025
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbarabashh thanks for your further work on this. The content is all there now, I think, I just had some suggestions on wording and ordering for you to look through. The bigger issue really is that the main explainer content is on the wrong page. I've included comments to help you put it on the right page, in the right place.

Thanks again.

dbarabashh and others added 7 commits April 14, 2025 16:13
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@bsmth bsmth added the awaiting response Awaiting for author to address review/feedback label Jul 16, 2025
@bsmth
Copy link
Member

bsmth commented Jul 16, 2025

Hi @dbarabashh - there's some review comments above if you'd like to come back to this. Have you addressed everything in recent commits? Thanks a lot!

@Josh-Cena Josh-Cena force-pushed the update-selection-inheritance branch from d914898 to bc8d746 Compare August 24, 2025 18:01
@Josh-Cena Josh-Cena removed the awaiting response Awaiting for author to address review/feedback label Aug 24, 2025
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, let's get this in. I've just made a small tweak to break up a long sentence.

@chrisdavidmills chrisdavidmills merged commit 37482c6 into mdn:main Aug 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new information about recent CSS inheritance changes with CSS selection and highlight pseudo-classes

4 participants