-
Notifications
You must be signed in to change notification settings - Fork 23.1k
Add new information about recent CSS inheritance changes with CSS selection and highlight pseudo-classes #38989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new information about recent CSS inheritance changes with CSS selection and highlight pseudo-classes #38989
Conversation
Preview URLs (6 pages)External URLs (1)URL:
(comment last updated: 2025-08-25 07:28:36) |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbarabashh thanks for the contribution! I've added some thoughts on how I think this could be handled.
|
I made some changes and updated the text, but I have a feeling its a bit hard to understand. Considering less experienced developers, this explanation might be too complex. What do you think? /cc @chrisdavidmills |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbarabashh It's getting there. A couple more comments for you.
I also wondered if you could link to this section from all the pseudo-element reference pages that follow this inheritance model?
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbarabashh thanks for your further work on this. The content is all there now, I think, I just had some suggestions on wording and ordering for you to look through. The bigger issue really is that the main explainer content is on the wrong page. I've included comments to help you put it on the right page, in the right place.
Thanks again.
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
|
Hi @dbarabashh - there's some review comments above if you'd like to come back to this. Have you addressed everything in recent commits? Thanks a lot! |
d914898 to
bc8d746
Compare
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, let's get this in. I've just made a small tweak to break up a long sentence.
Fix #36458