Update overrideContentColorScheme #39135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting only takes 3 values since Sept 2022 (see https://hg-edge.mozilla.org/integration/autoland/rev/edaed3aeb0f9 ) but those changes never got documented. Also not entirely clear as to whether the setting now applies browser or system theme - but I believe it is browser?
github-actions
bot
added
Content:WebExt
rebloor
requested changes
Apr 21, 2025
.../en-us/mozilla/add-ons/webextensions/api/browsersettings/overridecontentcolorscheme/index.md
Outdated
Show resolved
Hide resolved
Contributor
|
Preview URLs (comment last updated: 2025-04-22 02:36:15) |
…overridecontentcolorscheme/index.md Simplify sentence Co-authored-by: rebloor <git@sherpa.co.nz>
rebloor
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating this setting which only takes 3 values (since Sept 2022) but those changes never got documented. From the changes in
widget/nsXPLookAndFeel.cppyou can see that the "system" theme got removed and "auto" means what "browser" used to mean.Motivation
It is useful to have docs up-to-date with what they are trying to document.
Additional details
https://hg-edge.mozilla.org/integration/autoland/rev/edaed3aeb0f9
Related issues and pull requests
No related issues found.