Skip to content

Conversation

@estelle
Copy link
Member

@estelle estelle commented Apr 18, 2025

  • rewrote intro
  • added a description
  • added an example
  • the value is a comma-separated list of <mask-layer>s, so made the value section reflect this.
  • updated the see also (will add the guide when the guide is complete)
  • made the commenting in the syntax section shorter (i am ok with deleting them altogether if the reviewer is)

part of openwebdocs/project#224 and #39151

@estelle estelle requested a review from a team as a code owner April 18, 2025 03:40
@estelle estelle requested review from chrisdavidmills and removed request for a team April 18, 2025 03:40
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Apr 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

Preview URLs

Flaws (9)

URL: /en-US/docs/Web/CSS/mask
Title: mask
Flaw count: 9

  • broken_links:
    • /en-US/docs/Web/CSS/CSS_positioned_layout/Understanding_z-index/Stacking_context is a redirect
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/url which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/img which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/div which is a redirect

(comment last updated: 2025-04-21 05:39:39)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely work, @estelle. A few comments, but nothing major.

estelle and others added 2 commits April 18, 2025 22:02
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle estelle requested a review from chrisdavidmills April 19, 2025 05:08
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle all looking good, except for one structural snafu. Should be quick to fix, so I've approved it.


For this reason, the specification recommends using the `mask` shorthand rather than the individual component properties to override any masks set earlier in the cascade. This ensures that `mask-border` has also been reset.

### Values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ummm, you've ended up putting the "Description" section in the middle of the "Syntax" section. The "Values" section should be above the "Description" H2.

@estelle estelle merged commit c72bea5 into main Apr 21, 2025
12 checks passed
@estelle estelle deleted the estelle-patch-3 branch April 21, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants