-
Notifications
You must be signed in to change notification settings - Fork 23k
CSS mask property
#39186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS mask property
#39186
Conversation
|
Preview URLs Flaws (9)URL:
(comment last updated: 2025-04-21 05:39:39) |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely work, @estelle. A few comments, but nothing major.
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle all looking good, except for one structural snafu. Should be quick to fix, so I've approved it.
files/en-us/web/css/mask/index.md
Outdated
|
|
||
| For this reason, the specification recommends using the `mask` shorthand rather than the individual component properties to override any masks set earlier in the cascade. This ensures that `mask-border` has also been reset. | ||
|
|
||
| ### Values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ummm, you've ended up putting the "Description" section in the middle of the "Syntax" section. The "Values" section should be above the "Description" H2.
<mask-layer>s, so made the value section reflect this.part of openwebdocs/project#224 and #39151