Skip to content

Conversation

@estelle
Copy link
Member

@estelle estelle commented Apr 26, 2025

@estelle estelle requested a review from a team as a code owner April 26, 2025 08:53
@estelle estelle requested review from dipikabh and removed request for a team April 26, 2025 08:53
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Apr 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2025

Preview URLs

Flaws (4)

URL: /en-US/docs/Web/CSS/mask-mode
Title: mask-mode
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/CSS/mask-type
Title: mask-type
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

(comment last updated: 2025-05-06 16:56:57)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for the mask-type page

Comment on lines 30 to 33
- `alpha`
- : Indicates that the alpha values of the `<mask>` should be used.
- `luminance`
- : Indicates that the luminance values of the `<mask>` should be used.
Copy link
Contributor

@dipikabh dipikabh Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add examples here to better convey which values in the mask are used for alpha and luminance masking? For example, if fill="rgb(0 0 0 / 0.5)", it means 50% transparent. So the corresponding shape on the masked element will display at 50% opacity when using alpha as the value.
And a similar example for luminance will be helpful.
Quick examples here will be helpful along with the detailed explanations covered in "Description".

{{csssyntax}}

#### Result
## Examples
Copy link
Contributor

@dipikabh dipikabh Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about also demo'ing the effect of different mask-mode values, especially the effect of the non-default value. (similar to what's in the spec)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for mask-mode

estelle and others added 10 commits May 2, 2025 07:01
@estelle estelle requested a review from dipikabh May 2, 2025 06:03
@estelle
Copy link
Member Author

estelle commented May 2, 2025

{{svgattr("mask-type")}} will be supported once very shortly (when #39318 goes live)

@estelle
Copy link
Member Author

estelle commented May 6, 2025

Thanks @dipikabh. I think i caught everything and SVG mask-type attribute page is now live, so red should be gone.

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all the updates, @estelle!
I've suggested a few more improvements. But leaving a +1.

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle estelle merged commit d4af249 into main May 6, 2025
12 checks passed
@estelle estelle deleted the maskMode branch May 6, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants