-
Notifications
You must be signed in to change notification settings - Fork 23k
CSS properties: mask-mode and mask-type #39287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview URLs Flaws (4)URL:
URL:
(comment last updated: 2025-05-06 16:56:57) |
dipikabh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review for the mask-type page
| - `alpha` | ||
| - : Indicates that the alpha values of the `<mask>` should be used. | ||
| - `luminance` | ||
| - : Indicates that the luminance values of the `<mask>` should be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add examples here to better convey which values in the mask are used for alpha and luminance masking? For example, if fill="rgb(0 0 0 / 0.5)", it means 50% transparent. So the corresponding shape on the masked element will display at 50% opacity when using alpha as the value.
And a similar example for luminance will be helpful.
Quick examples here will be helpful along with the detailed explanations covered in "Description".
| {{csssyntax}} | ||
|
|
||
| #### Result | ||
| ## Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about also demo'ing the effect of different mask-mode values, especially the effect of the non-default value. (similar to what's in the spec)
dipikabh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review for mask-mode
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
{{svgattr("mask-type")}} will be supported once very shortly (when #39318 goes live) |
|
Thanks @dipikabh. I think i caught everything and SVG |
dipikabh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for all the updates, @estelle!
I've suggested a few more improvements. But leaving a +1.
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
part of openwebdocs/project#224 and #39151