Skip to content

Conversation

@estelle
Copy link
Member

@estelle estelle commented May 2, 2025

No description provided.

@estelle estelle requested a review from a team as a code owner May 2, 2025 09:39
@estelle estelle requested review from chrisdavidmills and removed request for a team May 2, 2025 09:39
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels May 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

Preview URLs

Flaws (2)

URL: /en-US/docs/Web/CSS/mask-origin
Title: mask-origin
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

(comment last updated: 2025-05-07 17:00:00)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @estelle! Looking pretty good. I had a few comments, but nothing major.


- `content-box`
- : The position is relative to the content box.
- `padding-box`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I found the description of this a bit confusing:

For single boxes 0 0 is the upper left corner of the padding edge, 100% 100% is the lower right corner.

It sounds almost like those numbers are possible values for mask-origin, but really they are mask-position values, right? Would it make more sense to say something like:

For single boxes, a {{cssxref("mask-position")}} of 0 0 is the upper left corner of the padding edge, whereas a mask-position of 100% 100% is the lower right corner.

?

Copy link
Member Author

@estelle estelle May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated this with links to what *-box means instead of explaining it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that works perfectly

estelle and others added 2 commits May 6, 2025 13:52
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
estelle and others added 2 commits May 6, 2025 14:09
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle estelle requested a review from chrisdavidmills May 6, 2025 12:32
@estelle
Copy link
Member Author

estelle commented May 6, 2025

boarding, but i think i got everything

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle couple of new comments for you to consider, but I'll approve this so you can merge when ready.

estelle and others added 2 commits May 7, 2025 09:57
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle estelle merged commit 19895ee into main May 7, 2025
11 checks passed
@estelle estelle deleted the maskOrigin branch May 7, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants