-
Notifications
You must be signed in to change notification settings - Fork 23k
CSS mask-origin property #39366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS mask-origin property #39366
Conversation
|
Preview URLs Flaws (2)URL:
(comment last updated: 2025-05-07 17:00:00) |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @estelle! Looking pretty good. I had a few comments, but nothing major.
|
|
||
| - `content-box` | ||
| - : The position is relative to the content box. | ||
| - `padding-box` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I found the description of this a bit confusing:
For single boxes
0 0is the upper left corner of the padding edge,100% 100%is the lower right corner.
It sounds almost like those numbers are possible values for mask-origin, but really they are mask-position values, right? Would it make more sense to say something like:
For single boxes, a {{cssxref("mask-position")}} of
0 0is the upper left corner of the padding edge, whereas amask-positionof100% 100%is the lower right corner.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated this with links to what *-box means instead of explaining it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that works perfectly
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
boarding, but i think i got everything |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle couple of new comments for you to consider, but I'll approve this so you can merge when ready.
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
No description provided.