Fix reflected element reference scope#40346
Merged
sideshowbarker merged 3 commits intomdn:mainfrom Jul 15, 2025
Merged
Conversation
hamishwillee
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
Contributor
|
Preview URLs Flaws (2)URL:
(comment last updated: 2025-07-15 07:50:31) |
jcsteh
reviewed
Jul 14, 2025
hamishwillee
commented
Jul 15, 2025
hamishwillee
commented
Jul 15, 2025
Co-authored-by: James Teh <jamie@jantrid.net>
hamishwillee
force-pushed
the
aria_reflected_element_references_scope
branch
from
2d58264 to
dc096d3
Compare
Collaborator
Author
|
@sideshowbarker This should now be good for an editorial review. Thanks so much @jcsteh for taking the time to help me fix this. |
sideshowbarker
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40294
The original doc stated that element references could target elements in parent but not nested scopes. That is true only for reflected element references - for attribute element references (i.e. in HTML) you can only reference elements in the same scope, because IDs are only valid in the scope in which they are declared.
I've split this out into two sections covering the scopes.
@jcsteh - Can you please sanity check the changes?