Skip to content

chore: move EmbedGH live sample into the page#40409

Merged
hamishwillee merged 2 commits intomdn:mainfrom
bsmth:media-error
Jul 18, 2025
Merged

chore: move EmbedGH live sample into the page#40409
hamishwillee merged 2 commits intomdn:mainfrom
bsmth:media-error

Conversation

@bsmth
Copy link
Copy Markdown
Member

@bsmth bsmth commented Jul 17, 2025

Description

Moves an EmbedGH live sample into the page.

Motivation

It's easier to maintain this way.

@bsmth bsmth requested a review from a team as a code owner July 17, 2025 12:53
@bsmth bsmth requested review from sideshowbarker and removed request for a team July 17, 2025 12:54
@github-actions github-actions Bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Jul 17, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 17, 2025

Preview URLs

(comment last updated: 2025-07-18 00:56:02)

@bsmth bsmth requested review from dipikabh and removed request for sideshowbarker July 17, 2025 14:00
Copy link
Copy Markdown
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'm here, yay.
We could do other things such as format this similar to the Web API examples etc. But that's in no way a requirement.

@hamishwillee hamishwillee merged commit 14121dd into mdn:main Jul 18, 2025
8 checks passed
@bsmth bsmth deleted the media-error branch July 18, 2025 08:10
@bsmth
Copy link
Copy Markdown
Member Author

bsmth commented Jul 18, 2025

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants