Lint: use named color if possible (2)#40621
Merged
Conversation
Josh-Cena
requested review from
chrisdavidmills,
fred-wang,
scottaohara and
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
Josh-Cena
requested review from
bsmth,
dipikabh and
estelle
and removed request for
a team,
chrisdavidmills,
fred-wang,
scottaohara and
sideshowbarker
Contributor
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Josh-Cena
force-pushed
the
named-color-2
branch
from
74fa01f to
8e5e80f
Compare
dipikabh
approved these changes
Aug 8, 2025
Contributor
dipikabh
left a comment
dipikabh
left a comment
There was a problem hiding this comment.
Looks good. Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #40228, we are a lot more explicit on some CSS stylistic decisions. In particular, we now have systematic rules surrounding the preferred color notations. As a starter, I'm porting all colors that have named equivalents to named colors, per our recommendation of using "common named colors". Afterwards, I'm going to convert the remaining colors to the preferred notation, such as preferring
rgb()and preferring number parameters.