Skip to content

Lint: always use long-form hex color (2)#40683

Merged
Josh-Cena merged 5 commits intomdn:mainfrom
Josh-Cena:hex-length-2
Aug 12, 2025
Merged

Lint: always use long-form hex color (2)#40683
Josh-Cena merged 5 commits intomdn:mainfrom
Josh-Cena:hex-length-2

Conversation

@Josh-Cena
Copy link
Copy Markdown
Member

After #40228, we are a lot more explicit on some CSS stylistic decisions. In particular, we now have systematic rules surrounding the preferred color notations. In this batch of PRs, I'm converting all short hex to long hex. The benefit is: readers can more easily understand the syntax; there's one less syntactic variability; if I want to grep all occurrences of one hex color, I can do that more easily without #aaa also matching #aaaddd.

@Josh-Cena Josh-Cena requested a review from a team as a code owner August 9, 2025 05:23
@Josh-Cena Josh-Cena requested review from bsmth, dipikabh, estelle and wbamberg and removed request for a team and wbamberg August 9, 2025 05:23
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Aug 9, 2025
Comment thread files/en-us/web/api/mediastreamtrack/mute_event/index.md Outdated
Comment thread files/en-us/web/api/mediastreamtrack/unmute_event/index.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 9, 2025

Preview URLs (67 pages)
Flaws (14)

Note! 60 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Document_Object_Model/Whitespace
Title: How whitespace is handled by HTML, CSS, and in the DOM
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/API/Document_Object_Model/Whitespace_in_the_DOM which is a redirect

URL: /en-US/docs/Web/API/Element/wheel_event
Title: Element: wheel event
Flaw count: 3

  • macros:
    • Can't resolve /en-US/docs/Web/API/WheelEvent/wheelDelta
    • Can't resolve /en-US/docs/Web/API/WheelEvent/wheelDeltaX
    • Can't resolve /en-US/docs/Web/API/WheelEvent/wheelDeltaY

URL: /en-US/docs/Web/API/HTMLButtonElement/reportValidity
Title: HTMLButtonElement: reportValidity() method
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/API/HTMLElement/invalid_event which is a redirect

URL: /en-US/docs/Web/API/SVGAnimationElement/beginEvent_event
Title: SVGAnimationElement: beginEvent event
Flaw count: 2

  • macros:
    • Can't resolve /en-US/docs/Web/API/TimeEvent/detail
    • Can't resolve /en-US/docs/Web/API/TimeEvent/view

URL: /en-US/docs/Web/API/SVGAnimationElement/endEvent_event
Title: SVGAnimationElement: endEvent event
Flaw count: 2

  • macros:
    • Can't resolve /en-US/docs/Web/API/TimeEvent/detail
    • Can't resolve /en-US/docs/Web/API/TimeEvent/view

URL: /en-US/docs/Web/API/SVGAnimationElement/repeatEvent_event
Title: SVGAnimationElement: repeatEvent event
Flaw count: 2

  • macros:
    • Can't resolve /en-US/docs/Web/API/TimeEvent/detail
    • Can't resolve /en-US/docs/Web/API/TimeEvent/view

URL: /en-US/docs/Web/API/Web_components/Using_templates_and_slots
Title: Using templates and slots
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/Web_Components/Using_custom_elements which is a redirect
    • Macro produces link /en-US/docs/Web/Web_Components/Using_shadow_DOM which is a redirect
    • Macro produces link /en-US/docs/Web/Web_Components/Using_templates_and_slots which is a redirect

(comment last updated: 2025-08-12 00:59:15)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment thread files/en-us/web/api/mediastreamtrack/unmute_event/index.md Outdated
Josh-Cena and others added 2 commits August 9, 2025 13:31
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just one change needed to lower case. Thanks!

Comment thread files/en-us/web/api/canvas_api/tutorial/transformations/index.md Outdated
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@Josh-Cena Josh-Cena merged commit bc9f7be into mdn:main Aug 12, 2025
8 checks passed
@Josh-Cena Josh-Cena deleted the hex-length-2 branch August 12, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants