Skip to content

Lint: always use long-form hex color (5)#40685

Merged
dipikabh merged 1 commit intomdn:mainfrom
Josh-Cena:hex-length-5
Aug 13, 2025
Merged

Lint: always use long-form hex color (5)#40685
dipikabh merged 1 commit intomdn:mainfrom
Josh-Cena:hex-length-5

Conversation

@Josh-Cena
Copy link
Copy Markdown
Member

After #40228, we are a lot more explicit on some CSS stylistic decisions. In particular, we now have systematic rules surrounding the preferred color notations. In this batch of PRs, I'm converting all short hex to long hex. The benefit is: readers can more easily understand the syntax; there's one less syntactic variability; if I want to grep all occurrences of one hex color, I can do that more easily without #aaa also matching #aaaddd.

@Josh-Cena Josh-Cena requested review from a team as code owners August 9, 2025 05:24
@Josh-Cena Josh-Cena requested review from Rob--W, chrisdavidmills and scottaohara and removed request for a team August 9, 2025 05:24
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebExt WebExtensions docs Content:Accessibility Accessibility docs Content:SVG SVG docs Content:Media Media docs Content:PWA Progressive Web Apps content labels Aug 9, 2025
@Josh-Cena Josh-Cena requested review from bsmth, dipikabh and estelle and removed request for a team, Rob--W, chrisdavidmills and scottaohara August 9, 2025 05:24
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Aug 9, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 9, 2025

Preview URLs (45 pages)
Flaws (7)

Note! 40 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTML/Reference/Elements/td
Title: <td>: The Table Data Cell element
Flaw count: 1

  • unknown:
    • Error opening /shared-assets/images/diagrams/html/table/column-row-span.png: No such file or directory (os error 2)

URL: /en-US/docs/Web/HTML/Reference/Elements/th
Title: <th>: The Table Header element
Flaw count: 1

  • unknown:
    • Error opening /shared-assets/images/diagrams/html/table/column-row-span.png: No such file or directory (os error 2)

URL: /en-US/docs/Web/Progressive_web_apps/Tutorials/CycleTracker/HTML_and_CSS
Title: CycleTracker: Base HTML and CSS
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/Progressive_web_apps/Tutorials/CycleTracker/ which is a redirect

URL: /en-US/docs/Web/SVG/Reference/Attribute/requiredFeatures
Title: requiredFeatures
Flaw count: 3

  • macros:
    • Can't resolve /en-US/docs/Web/SVG/Reference/Attribute/requiredExtensions
    • Can't resolve /en-US/docs/Web/SVG/Reference/Attribute/xlink:role
    • Can't resolve /en-US/docs/Web/SVG/Reference/Attribute/xlink:actuate

URL: /en-US/docs/Web/SVG/Reference/Element/feComposite
Title: <feComposite>
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/SVG/Reference/Element/discard which is a redirect

Copy link
Copy Markdown
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dipikabh dipikabh merged commit a1765c2 into mdn:main Aug 13, 2025
7 checks passed
@Josh-Cena Josh-Cena deleted the hex-length-5 branch August 13, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Accessibility Accessibility docs Content:HTML Hypertext Markup Language docs Content:Media Media docs Content:PWA Progressive Web Apps content Content:SVG SVG docs Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants