Skip to content

fix(pr-test): enable writer toolbar#41270

Merged
LeoMcA merged 1 commit intomainfrom
fred-writer-toolbar
Sep 24, 2025
Merged

fix(pr-test): enable writer toolbar#41270
LeoMcA merged 1 commit intomainfrom
fred-writer-toolbar

Conversation

@LeoMcA
Copy link
Copy Markdown
Member

@LeoMcA LeoMcA commented Sep 24, 2025

Relates to mdn/fred#730

I forgot I already added a localServer flag to our context:

https://github.com/mdn/fred/blob/4d6c46696ae10507eecb19f1bc6c323be0bef82e/server.js#L51

and used it in the writer toolbar to ensure things which require a local server don't appear when we don't have one:

https://github.com/mdn/fred/blob/4d6c46696ae10507eecb19f1bc6c323be0bef82e/components/writer-toolbar/server.js#L21

So the only change we should need to make is enabling the toolbar in the workflow.

I'll open a PR in translated content after it's successful here.

@LeoMcA LeoMcA requested a review from a team as a code owner September 24, 2025 09:45
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/s [PR only] 6-50 LoC changed labels Sep 24, 2025
@LeoMcA LeoMcA merged commit b1a4681 into main Sep 24, 2025
11 checks passed
@LeoMcA LeoMcA deleted the fred-writer-toolbar branch September 24, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants