Lint: HTML conformance/style fixes (2)#41771
Conversation
Preview URLs (74 pages)
Flaws (347)Note! 40 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLs (14)URL:
URL:
URL: (comment last updated: 2025-11-03 18:08:53) |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Thanks @Josh-Cena; these changes largely make sense. I just had a few comments for you to consider, but I'll approve this so as not to hold you up.
| <iframe src="https://example.com" allow="geolocation"></iframe | ||
| ></iframe> | ||
| <iframe src="https://example.com" allow="geolocation 'src'"></iframe> | ||
| <iframe src="https://example.com" allow="geolocation"></iframe> |
There was a problem hiding this comment.
I agree that the nesting is a bit weird, but I'm not sure if this example is now equivalent to the previous one, as the preceding text says. Would it be better to include just the first iframe in the block?
Also maybe update the preceding text to "...so the following is equivalent:"?
There was a problem hiding this comment.
This is actually the originally intended meaning. Before #24058, the example was written without closing tags and Prettier gets confused. The original text also had two "elements" juxtaposed, and I believe the intention is clear enough: we are comparing two elements within one code block.
| <iframe src="https://example.com" allow="geolocation 'src'"> | ||
| <iframe src="https://example.com" allow="geolocation"></iframe | ||
| ></iframe> | ||
| <iframe src="https://example.com" allow="geolocation 'src'"></iframe> |
There was a problem hiding this comment.
Same comment as for the Permissions Policy guide.
|
Just a heads up - we'll most likely move the at-rule pages under |
|
Thank for the heads up. I'm busy this morning but I'll get my recent PRs merged this afternoon. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
|
Thanks for the reviews @chrisdavidmills! A lot of these HTML errors are caused by the Prettier formatting, so I've just restored them to the intended, error-free meaning. |
Follow up of #41754.
vuecode blocks properly<iframe>children; I know this is for fallback but there's no reason to care about lack ofiframesupportsrc<menu>having non-lichildren<map>need a name, and if it has an id they need to be equal. Also slightly updated the docs forHTMLImageElement.useMapto reflect thisidshould be valid CSS identifiers<legend role="button">to use an actual button instead<and>; properly add trailing slashes for void elementsstreet-addressis not a validautocompletetoken for<input>; replaced with<textarea><label for="a"><output></output></label><input id="a">where we don't actually intend for theoutputto be a form control, so replaced it with<span>instead