-
Notifications
You must be signed in to change notification settings - Fork 23.1k
scroll-padding property update #42690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Clarified the definition of the scroll-padding property and its relation to the CSS scroll snap module. made 3rd example in try this very different from 2nd example fixes #42183
|
Preview URLs (1 page) Flaws (6) Found an unexpected or unresolvable flaw? Please report it here. URL:
(comment last updated: 2026-01-23 15:06:39) |
dipikabh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @estelle, thanks for taking this up.
The reported issue still exists. The sentence "This allows the author to exclude regions..." right after the "Try it" demo might still suggest that the demo is illustrating this scenario when it's not. Can we move this sentence to a "Description" section or better still, add an example that shows how the property can be used to prevent nav bars, for example, from obscuring content.
files/en-us/web/css/reference/properties/scroll-padding/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
|
Thanks, Estelle, this looks good and can be merged. However, since it doesn't address the reported issue, I'd suggest to remove the issue link from the PR description. |
The edit changes the try it demo. The 20% addresses the issue in the issue |
|
(Updated in order to see the review companion comment reflect the flaws with the latest rari version.) |
Added a detailed description of the scroll-padding property, including its purpose and usage in scroll-snap containers.
dipikabh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking much better now. Thank you!
files/en-us/web/css/reference/properties/scroll-padding/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/reference/properties/scroll-padding/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/reference/properties/scroll-padding/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Clarified the definition of the scroll-padding property and its relation to the CSS scroll snap module.
made 3rd example in try this very different from 2nd example
fixes #42183