Use cartesian distance for pinch zoom gesture#42728
Merged
sideshowbarker merged 2 commits intomdn:mainfrom Jan 19, 2026
Merged
Conversation
Pinch zoom gestures should use cartesian distance, because they are usually executed diagonally, and so that they can optionally be combined with a rotate gesture.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sideshowbarker
approved these changes
Jan 19, 2026
Contributor
Member
|
@atg, congrats on landing your first docs change here — welcome aboard 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinch zoom gestures should use cartesian distance, because they are usually executed diagonally, and so that they can optionally be combined with a rotate gesture.
Description
The previous code used the following distance calculation that only looks at the horizontal component of the pinch:
If you actually try to zoom like this, it's very challenging ergonomically: your thumb, index finger, hand and forearm and all on the same line, your arm wants to be perpendicular to your body and the trackpad, so doing a pinch zoom horizontally requires your forearm to be almost parallel to the trackpad. In other words, the vertical component is the primary component for a pinch zoom and the horizontal component is secondary.
Usually a pinch zoom is implemented as cartesian distance because it is complemented by the rotate gesture. So a 1 dimensional pinch zoom is inconsistent with user expectations.