Remove incorrect bubbling/cancelable info for IDBRequest error event #42844
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MUSKANNISHAD
requested review from
hamishwillee
and removed request for
a team
github-actions
bot
added
Content:HTML
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-01-30 08:22:46) |
MUSKANNISHAD
force-pushed
the
fix-idbrequest-error-event-bubbling
branch
from
e328283 to
003521c
Compare
github-actions
bot
added
size/xs
Collaborator
|
Can you please fix all the reviewdoc reports. |
MUSKANNISHAD
force-pushed
the
fix-idbrequest-error-event-bubbling
branch
from
003521c to
e11dac2
Compare
github-actions
bot
added
Content:HTML
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| <button>OK</button> | ||
| </form> | ||
| </dialog> | ||
| <dialog open><p>Greetings, one and all!</p><form method="dialog"><button>OK</button></form></dialog> |
Contributor
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| <dialog open><p>Greetings, one and all!</p><form method="dialog"><button>OK</button></form></dialog> | |
| <dialog open> | |
| <p>Greetings, one and all!</p> | |
| <form method="dialog"><button>OK</button></form> | |
| </dialog> |
MUSKANNISHAD
force-pushed
the
fix-idbrequest-error-event-bubbling
branch
from
e11dac2 to
4283101
Compare
github-actions
bot
added
size/xs
Contributor
Author
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42650
Removes an incorrect statement claiming the IDBRequest error event
does not bubble and is not cancelable.