-
Notifications
You must be signed in to change notification settings - Fork 23.1k
Issue assignment process clarification #42926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview URLs (1 page) External URLs (2)URL:
(comment last updated: 2026-02-01 22:50:43) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hamishwillee looks good, man; a couple of suggestions, but nothing major.
Also, while you're here, consider:
- Fixing the grammar issue in the first numbered bullet — "If you're looking to contribute, search for issues with" should be "If you're looking to contribute, search for issues with a"
- Adding a warning about not submitting AI slop fixes, as they waste our time as we will probably close them? Hrm, maybe this one requires more discussion.
caugner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my point of view, I'll let others approve.
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com> Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
|
Thanks all for the review - I have accepted all suggestions and fixed the typo. Chris, yes, would be great to add a comment on AI slop as a separate PR. |
dipikabh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on, Hamish! 🙌
I have a few rewording suggestions and a broader suggestion to adjust the step list to accommodate the current set of changes.
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my end.
dipikabh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Approving.
I'll check in on Monday to see how it shapes up.
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
|
Thanks for the review @dipikabh - much improved. Merging. |
The Guidelines for working on an issue suggest that users self assign if they can, and otherwise add a comment asking to be assigned.
In theory this is good - user asks to be assigned, and a core user then assigns them. Historically though this often doesn't work - you get people asking to be assigned to multiple issues, then getting assigned and doing no work. The issues then rot.
The current and well established process is that authors start work and create the cross link
Fixes #<issue no.>in the PR to implicitly assign the issue.This updates the process to reflect how assignment is actually handled on MDN.