Rename Payment Handler API --> Web-based Payment Handler API#43238
Rename Payment Handler API --> Web-based Payment Handler API#43238hamishwillee merged 2 commits intomdn:mainfrom
Conversation
stephenmcgruer
requested review from
hamishwillee
and removed request for
a team
github-actions
bot
added
Content:WebAPI
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
@stephenmcgruer Thanks very much.
Can you please also update https://github.com/mdn/content/blob/main/files/jsondata/GroupData.json#L1185
This defines the sidebar for Web API. It is why the flaw is being reported "Invalid slug for templ/sidebar: Web Based Payment Handler API" - because the macro for the sidebar can't find a key of that name.
Then test that the sidebar renders properly - just load locally and see that the interfaces are in the sidebar still when you look at the Payment API page.
Did you grep the rest of the document source to check for mention of the API?
|
Thanks for the review! I've now done a much more thorough pass, as well as learned a bit more about how MDN references work. Not ready for re-review quite yet, I just wanted to be able to examine my changes in the GitHub UI . Will flag for re-review when ready :). |
github-actions
bot
added
Content:Security
stephenmcgruer
force-pushed
the
web-based-payment-handlers
branch
2 times, most recently
from
e3ee1d1 to
bead4d3
Compare
This spec was renamed recently, see https://w3c.github.io/web-based-payment-handler/ Move was done via: npm run content move web/api/payment_handler_api Web/API/Web_Based_Payment_Handler_API node scripts/update-moved-file-links.js Then individual edits to files.
stephenmcgruer
force-pushed
the
web-based-payment-handlers
branch
from
bead4d3 to
958862d
Compare
stephenmcgruer
left a comment
stephenmcgruer
left a comment
There was a problem hiding this comment.
Ok, ready for review now I think.
| ## See also | ||
|
|
||
| - {{domxref("Payment Handler API", "Payment Handler API", "", "nocode")}} | ||
| - {{domxref("Web-based Payment Handler API", "", "", "nocode")}} |
There was a problem hiding this comment.
A number of files had what I believe is an unnecessary duplication of "Payment Handler API" here, because you only (?) need that if you want the rendered text to be different than the link/reference first parameter. Lmk if that wasn't correct and I can restore the duplication.
There was a problem hiding this comment.
Correct - this is if you want to use a different text to the page title.
FWIW
- personally I never use domxref for guide links because there is no benefit to it and the rendering is less clear to editors - I do
[Whatever text I want](https://pr43238.review.mdn.allizom.net/en-US/docs/Web/API/Web-Based_Payment_Handler_API).
But I don't bother changing it either when I see cases like this. - More generally, in the Web API section we are ambivalent about using domxref of a bare link. Again though, we don't change them to one or the other in review. CSS section takes a different view and always uses the macro.
| "properties": [], | ||
| "events": [] | ||
| }, | ||
| "Web-Based Payment Handler API": { |
There was a problem hiding this comment.
The two .json files appear to be in alphabetical order, but I wasn't sure how they treat the order of a dash "-" vs an alphabetical character. Lmk! :)
There was a problem hiding this comment.
I have no idea. Assume - is whitespace unless someone explicitly argues.
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
@stephenmcgruer Thanks very much.
FYI, the macro reference is case sensitive, so the related APIs were'n't working properly:
Fixed in 34432ee
2 participants
Description
Rename files referencing the "Payment Handler API" to "Web-based Payment Handler API"
Motivation
This spec was renamed recently, see
https://w3c.github.io/web-based-payment-handler/
Additional details
Move was done via:
Then individual edits to files.
Related issues and pull requests