Clarify that (lang="") means explicitly unknown, not default.#43413
Merged
Clarify that (lang="") means explicitly unknown, not default.#43413
Conversation
github-actions
bot
added
Content:HTML
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-03-12 14:04:25) |
pepelsbey
approved these changes
Mar 12, 2026
Member
pepelsbey
left a comment
pepelsbey
left a comment
There was a problem hiding this comment.
Looks good! Thank you 🙂
I have a small suggestion.
Contributor
Author
|
Thanks for suggestions and the review @pepelsbey! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous note on the
langattribute said the default value is the empty string.That was incorrect, the empty string only applies when the attribute is explicitly set, which signals the language is explicitly
unknown.Spec reference:
This PR updates the note to be spec-accurate and complements the inheritance section.
Preview
Note
If the value of
langis set to empty string the language is explicitly unknown. Therefore, it is recommended to always specify an appropriate value for this attribute.fixes #43259