WebDriver conformance changes for Firefox 149#43492
Conversation
|
Preview URLs (1 page) External URLs (11)URL:
(comment last updated: 2026-03-20 13:59:11) |
whimboo
left a comment
There was a problem hiding this comment.
I've some suggestions but otherwise it looks good to me. Thanks!
| #### WebDriver BiDi | ||
|
|
||
| - Added support for automatic user prompt handling, which can be configured through capabilities with the `session.new` command. ([Firefox bug 1905086](https://bugzil.la/1905086)). | ||
| - Implemented the `browser.setDownloadBehavior` command, which lets clients allow or prohibit the downloads and also set a custom download folder. This behavior can be configured per session or per user contexts. ([Firefox bug 1989022](https://bugzil.la/1989022)). |
There was a problem hiding this comment.
To stay in sync with former release notes:
| - Implemented the `browser.setDownloadBehavior` command, which lets clients allow or prohibit the downloads and also set a custom download folder. This behavior can be configured per session or per user contexts. ([Firefox bug 1989022](https://bugzil.la/1989022)). | |
| - Added the `browser.setDownloadBehavior` command, which lets clients allow or prohibit the downloads and also set a custom download folder. This behavior can be configured per session or per user contexts. ([Firefox bug 1989022](https://bugzil.la/1989022)). |
There was a problem hiding this comment.
We use implemented in the notes for other releases (e.g., 145 or 147). I don't really see the clear pattern here (and I don't think we need it).
There was a problem hiding this comment.
I would say it’s easier to quickly parse release notes when every item starts with Added, Updated, Fixed. Ideally, they would be grouped in the same list or even into sections. With sections, we won’t even need Added, Updated, Fixed:
Added
- Support for automatic user prompt handling
browser.setDownloadBehaviorcommand
Updated
- Logic of applying different settings
Fixed
- Issue where the
browsingContext.userPromptOpened - Serialization for DOM nodes
There was a problem hiding this comment.
Alright, that makes sense! To not introduce sections now (we can maybe discuss it for future updates), I, for now, just updated all the implement items to start with add and grouped them together.
Co-authored-by: Henrik Skupin <mail@hskupin.info>
pepelsbey
left a comment
There was a problem hiding this comment.
Looks good! Thank you 🙂
Left a non-critical opinion 😬
| #### WebDriver BiDi | ||
|
|
||
| - Added support for automatic user prompt handling, which can be configured through capabilities with the `session.new` command. ([Firefox bug 1905086](https://bugzil.la/1905086)). | ||
| - Implemented the `browser.setDownloadBehavior` command, which lets clients allow or prohibit the downloads and also set a custom download folder. This behavior can be configured per session or per user contexts. ([Firefox bug 1989022](https://bugzil.la/1989022)). |
There was a problem hiding this comment.
I would say it’s easier to quickly parse release notes when every item starts with Added, Updated, Fixed. Ideally, they would be grouped in the same list or even into sections. With sections, we won’t even need Added, Updated, Fixed:
Added
- Support for automatic user prompt handling
browser.setDownloadBehaviorcommand
Updated
- Logic of applying different settings
Fixed
- Issue where the
browsingContext.userPromptOpened - Serialization for DOM nodes
This PR contains all the changes to WebDriver BiDi and Marionette for the Firefox 149 release.