Node.js server without a framework: decodeURI#43579
Merged
hamishwillee merged 1 commit intomdn:mainfrom Mar 27, 2026
Merged
Conversation
In general case, decoding URI is needed to transform it to a usable file path without %percent encoded whitespaces etc.
github-actions
bot
added
Content:Learn
Contributor
Author
|
Might also wanna strip ?query= params as well. Those are sometimes used with a dummy value just to bypass caching. |
chrisdavidmills
requested review from
hamishwillee
and removed request for
a team
Contributor
|
Preview URLs (1 page) |
hamishwillee
approved these changes
Mar 27, 2026
Collaborator
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
Thanks @ratijas - and congrats on landing your first PR merge.
Might also wanna strip ?query= params as well. Those are sometimes used with a dummy value just to bypass caching.
We could, but I don't think it is necessary. Would consider a PR, but not sure it would add much as a "teaching opportunity".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In general case, decoding URI is needed to transform it to a usable file path without %percent encoded whitespaces etc.