Skip to content

Editorial review: Document NavigationTransition.committed#43692

Open
chrisdavidmills wants to merge 2 commits intomdn:mainfrom
chrisdavidmills:navigationtransition-to
Open

Editorial review: Document NavigationTransition.committed#43692
chrisdavidmills wants to merge 2 commits intomdn:mainfrom
chrisdavidmills:navigationtransition-to

Conversation

@chrisdavidmills
Copy link
Copy Markdown
Contributor

@chrisdavidmills chrisdavidmills commented Apr 7, 2026

Description

Chrome 145 adds support for the NavigationTransition.to property; see https://chromestatus.com/feature/6008183302782976. I originally added a doc for to in this PR, but then removed it again as it is already added in #43626.

This PR still adds reference documentation for NavigationTransition.committed, as we were missing that.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner April 7, 2026 13:39
@chrisdavidmills chrisdavidmills requested review from dipikabh and removed request for a team April 7, 2026 13:39
@chrisdavidmills chrisdavidmills changed the title Document NavigationTransition.to and.committed Document NavigationTransition.to and .committed Apr 7, 2026
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Apr 7, 2026
@chrisdavidmills chrisdavidmills changed the title Document NavigationTransition.to and .committed Technical review: Document NavigationTransition.to and .committed Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Preview URLs (2 pages)

External URLs (2)

URL: /en-US/docs/Web/API/NavigationTransition/committed
Title: NavigationTransition: committed property

(comment last updated: 2026-04-07 14:54:53)

@chrisdavidmills
Copy link
Copy Markdown
Contributor Author

@noamr, can you cast your eye over this one to see whether it is accurate, and if there is anything else you'd like to see added? Thanks!

@noamr
Copy link
Copy Markdown
Contributor

noamr commented Apr 7, 2026

@noamr, can you cast your eye over this one to see whether it is accurate, and if there is anything else you'd like to see added? Thanks!

This seems to conflict with #43626?

@chrisdavidmills
Copy link
Copy Markdown
Contributor Author

@noamr, can you cast your eye over this one to see whether it is accurate, and if there is anything else you'd like to see added? Thanks!

This seems to conflict with #43626?

Darnit, I totally missed that. I'll update it to just add committed.

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Apr 7, 2026
@chrisdavidmills chrisdavidmills changed the title Technical review: Document NavigationTransition.to and .committed Technical review: Document NavigationTransition.committed Apr 7, 2026
@chrisdavidmills
Copy link
Copy Markdown
Contributor Author

Darnit, I totally missed that. I'll update it to just add committed.

OK, done.

Copy link
Copy Markdown
Contributor

@noamr noamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisdavidmills chrisdavidmills changed the title Technical review: Document NavigationTransition.committed Editorial review: Document NavigationTransition.committed Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants