linking to <dimension> and CSS Units & Values from CSSUnitValue#43699
Merged
chrisdavidmills merged 12 commits intomdn:mainfrom Apr 9, 2026
Merged
linking to <dimension> and CSS Units & Values from CSSUnitValue#43699chrisdavidmills merged 12 commits intomdn:mainfrom
chrisdavidmills merged 12 commits intomdn:mainfrom
Conversation
added See Also and link to <dimension>
Added link to <dimension> and some reference links to all types of units
Update index.md
can be any numeric data type, not just <dimension>. also better examples
Contributor
|
Preview URLs (2 pages) (comment last updated: 2026-04-09 09:58:39) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chrisdavidmills
requested changes
Apr 8, 2026
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
Thanks for the edit, @nickyonge — I think these additions are pretty useful. I've made some small casing changes to some of the "See also" links, and I've left a suggestion for you about one sentence that had gotten a bit muddled.
Apart from that, looking good.
thanks chris! Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Contributor
Author
|
thank you @chrisdavidmills :) added your suggestion. Clarity is always a win~ |
chrisdavidmills
approved these changes
Apr 9, 2026
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
Perfect, let's get this one in. Thanks again, @nickyonge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a couple links to CSSUnitValue and unit
Description
Links to (because that's what we're working with) and the CSS Units and Values page, to have a direct reference to all possible values for unit.
Motivation
I jumped to the docs from VS Code to see what values I could use in a parser that I was writing, and was surprised to find nothing more detailed than the "em" and "px" in the example. I had to hop back to google to find that list, so just linked it here
Additional details
m/a
Related issues and pull requests
n/a, just a couple extra lines in the docs :)