updated data collection permissions with strict Firefox version#43792
updated data collection permissions with strict Firefox version#43792
Conversation
|
Preview URLs (1 page) (comment last updated: 2026-04-15 12:05:18) |
rebloor
left a comment
There was a problem hiding this comment.
@narasimhan-lakshmi thanks for tackling this change. I've left a suggestion for a couple of improvements.
…r_specific_settings/index.md Co-authored-by: rebloor <git@sherpa.co.nz>
…r_specific_settings/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rebloor
left a comment
There was a problem hiding this comment.
Thanks @narasimhan-lakshmi
| "none" | ||
| ] | ||
| }, | ||
| "strict_min_version": "58.0" |
There was a problem hiding this comment.
Why revert back to 58? (accident?)
Users will need to use 140, otherwise it won't work during addon submission due to usage of new data_collection_permissions key:
https://extensionworkshop.com/documentation/develop/firefox-builtin-data-consent/#data-collection-experience-on-older-Firefox-versions
There was a problem hiding this comment.
No, they only need to set strict_min_version to 140 if they don't intend to provide a custom experience for early versions.
There was a problem hiding this comment.
When you run the extension on Firefox 139, it doesn't display the built-in data-collection dialog. Hence, the point of Data collection experience on older Firefox versions. Extensions that collect data covered by the extension policies and want to run on 139 or earlier have to add a custom dialog for data consent (or disable data collection).
There was a problem hiding this comment.
I'm not talking about running Firefox, I'm only saying that submitting addon to the store with anything lower than 140 in the strict_min_version value will produce the warning above.
And using lower number and removing the data_collection_permissions will produce also a warning:
So the best way, that will not confuse new developers, is to use 140 and the data_collection_permissions as is in the example.
Only that will produce no warnings and everyone is happy :)
It's not like there is a reason to support anything below 140 anymore, right?
There was a problem hiding this comment.
The example is valid and can be used with any version of Firefox from 58 onward. Using the value of 140 could give the incorrect impression that data_collection_permissions can't be specified in extensions targeting versions before 140.

Description
Added data_collection_permissions with required: ["none"]
Updated strict_min_version to "140.0"
Motivation
makes reader to view in updated version environment
Additional details
Related issues and pull requests
Fixes #43574