Skip to content

updated data collection permissions with strict Firefox version#43792

Merged
rebloor merged 3 commits intomdn:mainfrom
narasimhan-lakshmi:fix/data-collection-permission
Apr 15, 2026
Merged

updated data collection permissions with strict Firefox version#43792
rebloor merged 3 commits intomdn:mainfrom
narasimhan-lakshmi:fix/data-collection-permission

Conversation

@narasimhan-lakshmi
Copy link
Copy Markdown
Contributor

Description

Added data_collection_permissions with required: ["none"]
Updated strict_min_version to "140.0"

Motivation

makes reader to view in updated version environment

Additional details

Related issues and pull requests

Fixes #43574

@narasimhan-lakshmi narasimhan-lakshmi requested a review from a team as a code owner April 14, 2026 16:53
@narasimhan-lakshmi narasimhan-lakshmi requested review from rebloor and removed request for a team April 14, 2026 16:53
@github-actions github-actions bot added Content:WebExt WebExtensions docs size/xs [PR only] 0-5 LoC changed labels Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

Preview URLs (1 page)

(comment last updated: 2026-04-15 12:05:18)

Copy link
Copy Markdown
Contributor

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narasimhan-lakshmi thanks for tackling this change. I've left a suggestion for a couple of improvements.

…r_specific_settings/index.md

Co-authored-by: rebloor <git@sherpa.co.nz>
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Apr 15, 2026
…r_specific_settings/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebloor rebloor merged commit 4b57695 into mdn:main Apr 15, 2026
9 checks passed
"none"
]
},
"strict_min_version": "58.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why revert back to 58? (accident?)
Users will need to use 140, otherwise it won't work during addon submission due to usage of new data_collection_permissions key:
https://extensionworkshop.com/documentation/develop/firefox-builtin-data-consent/#data-collection-experience-on-older-Firefox-versions

Copy link
Copy Markdown
Contributor

@rebloor rebloor Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they only need to set strict_min_version to 140 if they don't intend to provide a custom experience for early versions.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it now using web-ext lint command available in the web-ext tool.
If I set strict_min_version to 139 I get this warning:

image

It's very likely people will see this warning upon submission to the addons store.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you run the extension on Firefox 139, it doesn't display the built-in data-collection dialog. Hence, the point of Data collection experience on older Firefox versions. Extensions that collect data covered by the extension policies and want to run on 139 or earlier have to add a custom dialog for data consent (or disable data collection).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not talking about running Firefox, I'm only saying that submitting addon to the store with anything lower than 140 in the strict_min_version value will produce the warning above.
And using lower number and removing the data_collection_permissions will produce also a warning:

image

So the best way, that will not confuse new developers, is to use 140 and the data_collection_permissions as is in the example.
Only that will produce no warnings and everyone is happy :)
It's not like there is a reason to support anything below 140 anymore, right?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is valid and can be used with any version of Firefox from 58 onward. Using the value of 140 could give the incorrect impression that data_collection_permissions can't be specified in extensions targeting versions before 140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebExt WebExtensions docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend example with "data_collection_permissions" field, which is now mandatory

4 participants