[Editorial review] BiDi - Add pages for input module commands and event#43919
Conversation
Preview URLs (6 pages)
Flaws (16)Note! 1 document with no flaws that don't need to be listed. 🎉 Found an unexpected or unresolvable flaw? Please report it here. URL:
URL:
URL:
URL:
URL:
External URLs (1)URL:
(comment last updated: 2026-05-20 16:55:59) |
whimboo
left a comment
There was a problem hiding this comment.
Thank you for starting work on this module. It's clearly the most complicated one because it includes the action commands. For these I have indeed the most feedback for you. Please see my inline comments for all of these.
|
Thanks a lot for the review, @whimboo! |
|
Thanks for the feedback, @whimboo. I've added changes for outer and inner and also updated |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
whimboo
left a comment
There was a problem hiding this comment.
Thank you for all the updates. It looks good to me now.
|
Hi Vadim, this is now ready for an editorial review - would appreciate your feedback. Thanks! |
pepelsbey
left a comment
There was a problem hiding this comment.
Looks good! Thank you 🙂
A few minor suggestions below.
|
|
||
| - `value` | ||
| - : A string that contains the key value, such as <kbd>a</kbd>, <kbd>Enter</kbd>, or <kbd>Shift</kbd>. | ||
| See [Key values for keyboard events](/en-US/docs/Web/API/UI_Events/Keyboard_event_key_values) for the full list of valid values. |
There was a problem hiding this comment.
Looking at the example, the actual value is a Unicode sequence like \uE008 and we don’t have them listed on the MDN page. But they are listed in the spec: https://w3c.github.io/webdriver/#keyboard-actions
It might be worth adding both links or just the spec one. Not sure!
There was a problem hiding this comment.
Thanks for flagging this. You're right!
I've updated the link to point to the section in spec for now. We could consider adding that table to the WebDriver reference in a follow-up.
Also adjusted the phrasing slightly:
value
- : A string that contains the key value.
Specify this when the innertypefield value is"keyDown"or"keyUp".
For special keys such as Shift or Enter, use the Unicode code points defined in the WebDriver keyboard actions table (for example,"\uE008"for the Shift key). For printable characters, use the character directly (for example,"a").
|
Thanks for the review, @pepelsbey! |
Description
This PR adds the following pages:
input.performActionsinput.releaseActionsinput.setFilesinput.fileDialogOpenedQuick note about short-titles in front matter: In this module, I've used shorter short-titles (eg, performActions instead of input.performActions) - this only affects command (and event) names in the sidebar and breadcrumb. I'll update the short-titles in the already published
session,browser, andlogmodules in a follow-up PR.Spec links
Related issue
Doc issue: mdn/mdn#339