Skip to content

[Editorial review] BiDi - Add pages for input module commands and event#43919

Merged
dipikabh merged 13 commits into
mdn:mainfrom
dipikabh:bidi-input
May 20, 2026
Merged

[Editorial review] BiDi - Add pages for input module commands and event#43919
dipikabh merged 13 commits into
mdn:mainfrom
dipikabh:bidi-input

Conversation

@dipikabh
Copy link
Copy Markdown
Contributor

@dipikabh dipikabh commented Apr 24, 2026

Description

This PR adds the following pages:

  • input.performActions
  • input.releaseActions
  • input.setFiles
  • input.fileDialogOpened

Quick note about short-titles in front matter: In this module, I've used shorter short-titles (eg, performActions instead of input.performActions) - this only affects command (and event) names in the sidebar and breadcrumb. I'll update the short-titles in the already published session, browser, and log modules in a follow-up PR.

Spec links

Related issue

Doc issue: mdn/mdn#339

@dipikabh dipikabh requested a review from a team April 24, 2026 00:40
@dipikabh dipikabh requested review from a team as code owners April 24, 2026 00:40
@dipikabh dipikabh requested review from pepelsbey and removed request for a team April 24, 2026 00:40
@github-actions github-actions Bot added the Content:WebDriver WebDriver docs label Apr 24, 2026
@dipikabh dipikabh removed request for a team and pepelsbey April 24, 2026 00:40
@github-actions github-actions Bot added the size/m [PR only] 51-500 LoC changed label Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Preview URLs (6 pages)
Flaws (16)

Note! 1 document with no flaws that don't need to be listed. 🎉

Found an unexpected or unresolvable flaw? Please report it here.

URL: /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/input/fileDialogOpened
Title: input.fileDialogOpened event
Flaw count: 1

  • broken_links:
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/browsingContext/getTree doesn't resolve

URL: /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/input/performActions
Title: input.performActions command
Flaw count: 7

  • broken_links:
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/browsingContext/getTree doesn't resolve
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/browsingContext/locateNodes doesn't resolve
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/script/evaluate doesn't resolve
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/script/callFunction doesn't resolve
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/browsingContext/getTree doesn't resolve
    • and 2 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/input/releaseActions
Title: input.releaseActions command
Flaw count: 1

  • broken_links:
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/browsingContext/getTree doesn't resolve

URL: /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/input/setFiles
Title: input.setFiles command
Flaw count: 6

  • broken_links:
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/browsingContext/getTree doesn't resolve
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/browsingContext/locateNodes doesn't resolve
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/script/evaluate doesn't resolve
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/script/callFunction doesn't resolve
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/browsingContext/locateNodes doesn't resolve
    • and 1 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/session/subscribe
Title: session.subscribe command
Flaw count: 1

  • broken_links:
    • Link /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/browsingContext/getTree doesn't resolve
External URLs (1)

URL: /en-US/docs/Web/WebDriver/Reference/BiDi/Modules/input/performActions
Title: input.performActions command

(comment last updated: 2026-05-20 16:55:59)

@github-actions github-actions Bot added size/l [PR only] 501-1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Apr 27, 2026
@dipikabh dipikabh changed the title [Technical review] BiDi - Add pages for input module commands [Technical review] BiDi - Add pages for input module commands and event Apr 27, 2026
Copy link
Copy Markdown
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for starting work on this module. It's clearly the most complicated one because it includes the action commands. For these I have indeed the most feedback for you. Please see my inline comments for all of these.

Comment thread files/en-us/web/webdriver/reference/bidi/modules/input/performactions/index.md Outdated
Comment thread files/en-us/web/webdriver/reference/bidi/modules/input/performactions/index.md Outdated
Comment thread files/en-us/web/webdriver/reference/bidi/modules/input/performactions/index.md Outdated
Comment thread files/en-us/web/webdriver/reference/bidi/modules/input/performactions/index.md Outdated
Comment thread files/en-us/web/webdriver/reference/bidi/modules/input/releaseactions/index.md Outdated
@dipikabh
Copy link
Copy Markdown
Contributor Author

dipikabh commented May 4, 2026

Thanks a lot for the review, @whimboo!
I think I have addressed all the feedback. Let me know if any updates are required.

@dipikabh
Copy link
Copy Markdown
Contributor Author

dipikabh commented May 6, 2026

Thanks for the feedback, @whimboo.

I've added changes for outer and inner and also updated duration and the example code to demo duration in two parallel outer actions. PTAL

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Copy Markdown
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the updates. It looks good to me now.

Comment thread files/en-us/web/webdriver/reference/bidi/modules/input/performactions/index.md Outdated
@dipikabh dipikabh changed the title [Technical review] BiDi - Add pages for input module commands and event [Editorial review] BiDi - Add pages for input module commands and event May 13, 2026
@dipikabh
Copy link
Copy Markdown
Contributor Author

Hi Vadim, this is now ready for an editorial review - would appreciate your feedback. Thanks!

@dipikabh dipikabh requested a review from pepelsbey May 13, 2026 02:18
Copy link
Copy Markdown
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 🙂

A few minor suggestions below.

Comment thread files/en-us/web/webdriver/reference/bidi/modules/input/filedialogopened/index.md Outdated
Comment thread files/en-us/web/webdriver/reference/bidi/modules/input/index.md Outdated
Comment thread files/en-us/web/webdriver/reference/bidi/modules/input/setfiles/index.md Outdated

- `value`
- : A string that contains the key value, such as <kbd>a</kbd>, <kbd>Enter</kbd>, or <kbd>Shift</kbd>.
See [Key values for keyboard events](/en-US/docs/Web/API/UI_Events/Keyboard_event_key_values) for the full list of valid values.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the example, the actual value is a Unicode sequence like \uE008 and we don’t have them listed on the MDN page. But they are listed in the spec: https://w3c.github.io/webdriver/#keyboard-actions

It might be worth adding both links or just the spec one. Not sure!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging this. You're right!

I've updated the link to point to the section in spec for now. We could consider adding that table to the WebDriver reference in a follow-up.

Also adjusted the phrasing slightly:

  • value
    • : A string that contains the key value.
      Specify this when the inner type field value is "keyDown" or "keyUp".
      For special keys such as Shift or Enter, use the Unicode code points defined in the WebDriver keyboard actions table (for example, "\uE008" for the Shift key). For printable characters, use the character directly (for example, "a").

Comment thread files/en-us/web/webdriver/reference/bidi/modules/input/performactions/index.md Outdated
Comment thread files/en-us/web/webdriver/reference/bidi/modules/input/performactions/index.md Outdated
Comment thread files/en-us/web/webdriver/reference/bidi/modules/input/index.md Outdated
@dipikabh
Copy link
Copy Markdown
Contributor Author

Thanks for the review, @pepelsbey!
All valid suggestions. I've incorporated them all.

@dipikabh dipikabh merged commit 0e3eb29 into mdn:main May 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebDriver WebDriver docs size/l [PR only] 501-1000 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants